Skip to content

Conversation

@liquiddandruff
Copy link

Would be nice for results to be in bold like in past versions; would help quite a bit for visibility.

Is this a good way to accomplish this?

@liquiddandruff liquiddandruff changed the title Bolded results Bolded results & equals sign toggle Sep 1, 2014
@heldercorreia
Copy link
Collaborator

Thanks, appreciate your contribution. My only worry is whether this will break the session loading and saving code. Could you please verify that?

@liquiddandruff
Copy link
Author

I have successfully saved and loaded several sessions with and without the equals sign indicator toggled, and everything seems to work as intended.

@stevenhoneyman
Copy link
Contributor

The forced bold font makes mine look really bad - probably because the font I use for this doesn't have bold (or italic) options. Might be worth detecting somehow/making it optional?

2014-09-04_t211335_188x142_scrot

@liquiddandruff
Copy link
Author

Making it optional would be the best, although I'm not sure if more toggleable options like this in the menu would be the best way to do it; I feel it would get big and unwieldy. What are your thoughts?

Yes, perhaps if the font does not have the bold style then we can disable the bold.
edit: though it seems to already do this if I switch to fonts that lack the bold style..

@heldercorreia
Copy link
Collaborator

Finally got some time to review this... I'm not sure about the bold result thing. I'd much rather leave it for when user-defined themes are possible (and font properties like bold and italic would be part of it). Also, when you copy a result or part of it to the editor and evaluate, the expression on the result display will be bold. I'm OK with the = sign part though. Do you mind preparing a pull request only with it?

@liquiddandruff
Copy link
Author

I've removed the bolded results. How does it look now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants