-
Notifications
You must be signed in to change notification settings - Fork 39
Bolded results & equals sign toggle #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks, appreciate your contribution. My only worry is whether this will break the session loading and saving code. Could you please verify that? |
|
I have successfully saved and loaded several sessions with and without the equals sign indicator toggled, and everything seems to work as intended. |
|
Making it optional would be the best, although I'm not sure if more toggleable options like this in the menu would be the best way to do it; I feel it would get big and unwieldy. What are your thoughts? Yes, perhaps if the font does not have the bold style then we can disable the bold. |
|
Finally got some time to review this... I'm not sure about the bold result thing. I'd much rather leave it for when user-defined themes are possible (and font properties like bold and italic would be part of it). Also, when you copy a result or part of it to the editor and evaluate, the expression on the result display will be bold. I'm OK with the = sign part though. Do you mind preparing a pull request only with it? |
|
I've removed the bolded results. How does it look now? |

Would be nice for results to be in bold like in past versions; would help quite a bit for visibility.
Is this a good way to accomplish this?