-
Notifications
You must be signed in to change notification settings - Fork 1
Upgrade to Node.js 24 LTS #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Dockerfile: node:23-alpine → node:24-alpine - package.json: engines updated to Node.js >=24.x, npm >=11.x - GitHub Actions: daily PR workflow upgraded to Node.js 24 - Dockerfile: remove wget version pin for Alpine compatibility
WalkthroughThe pull request upgrades Node.js references to v24 across CI, container, and manifest: .github/workflows/daily-pr-count.yml now uses actions/setup-node v5 with node 24, the Dockerfile base images move from node:23-alpine to node:24-alpine, and website/package.json engines require node >=24.x and npm >=11.x. The Dockerfile also updates a wget package pin, creates a non-root appuser/appgroup and switches to it, exposes port 3000, and sets CMD ["npm","start"]. Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Vulnerabilities of
|
| digest | sha256:6f2a28761c80ed85b35444c1b7d938c429b90cdb881ee97d2c07ea95af876aed |
| vulnerabilities | |
| platform | linux/amd64 |
| size | 174 MB |
| packages | 981 |
📦 Base Image node:24-alpine
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/daily-pr-count.yml:
- Around line 21-24: Update the GitHub Actions step that uses
actions/setup-node@v3 to a supported version (actions/setup-node@v5 or later) so
the runner uses a Node24-based action; locate the "Set up Node.js" step in the
workflow and change the uses field from actions/setup-node@v3 to
actions/setup-node@v5 (or a later semver like `@v5.x`) while keeping the existing
node-version: 24 setting to ensure compatibility with current GitHub-hosted
runners.
In `@Dockerfile`:
- Around line 26-27: Pin the base image and either pin or make wget transient:
replace the mutable FROM tag with a digest-pinned base (e.g., use
node:24-alpine3.23@sha256:<digest>) to ensure reproducible builds, and update
the RUN step that currently states "RUN apk add --no-cache wget" to either
install the specific wget package version for Alpine 3.23 (wget 1.25.0-r2) or
install it as a temporary virtual package (apk add --no-cache --virtual .health
wget) and remove it in the same layer so the tool doesn't persist in the final
image; adjust the Dockerfile's RUN and FROM lines accordingly.
Uh oh!
There was an error while loading. Please reload this page.