Fixing user alerts #244
Merged
Fixing user alerts #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…identally omitted
lucaspar
added
bug
|
Review changes with Changed Files
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes user alerts not being displayed due to incorrect template block structure. The main issue was that messages and notifications were rendered inside the {% block body %} in base.html, which meant child templates that overrode this block wouldn't display alerts.
Changes:
- Moved message and notification rendering in base.html outside the body block to ensure they appear on all pages
- Added support for "danger" tag in toast component to align with Bootstrap conventions
- Restructured file_list.html template blocks (changed from
bodytocontentblock) - Updated allauth alert styling to use Bootstrap's standard
alert-dangerclass
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/sds_gateway/users/mixins.py | Added extra_tags="danger" to error message for Bootstrap compatibility |
| gateway/sds_gateway/templates/users/file_list.html | Restructured template blocks and added CSS/JS resources |
| gateway/sds_gateway/templates/users/components/toast.html | Added support for "danger" type and increased toast display duration |
| gateway/sds_gateway/templates/base.html | Moved messages/notifications outside body block and added Font Awesome globally |
| gateway/sds_gateway/templates/allauth/elements/alert.html | Changed from alert-error to Bootstrap-standard alert-danger class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
klpoland
approved these changes
Jan 14, 2026
Collaborator
klpoland
left a comment
klpoland
left a comment
There was a problem hiding this comment.
Yes, I noticed this too and didn't get around to fixing it. Thanks for cleaning this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User alerts weren't being displayed in most situations due to an incorrect block override in the template.