-
Notifications
You must be signed in to change notification settings - Fork 0
Putting visualization app behind feature flag #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a feature flag VISUALIZATIONS_ENABLED to conditionally enable or disable the visualizations functionality in the SDS Gateway. This allows deployments to control whether the visualization features are available without needing to modify code.
Key changes:
- Added
VISUALIZATIONS_ENABLEDsetting in base.py with a default value of True - Made visualization URLs conditionally included based on the feature flag
- Wrapped visualization-related template includes in conditional checks
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/docs/mkdocs/changelog.md | Changed release date for version 0.1.17 from a specific date to a placeholder |
| gateway/sds_gateway/templates/users/partials/capture_modal.html | Added conditional rendering of the Visualize button and visualization modal based on feature flag |
| gateway/sds_gateway/templates/users/file_list.html | Added conditional inclusion of visualization modal template based on feature flag |
| gateway/config/urls.py | Made visualization URLs conditionally included in urlpatterns based on feature flag |
| gateway/config/settings/base.py | Added VISUALIZATIONS_ENABLED setting with environment variable support |
| gateway/.envs/example/django.prod-example.env | Added VISUALIZATIONS_ENABLED variable and standardized boolean values to lowercase |
| gateway/.envs/example/django.env | Added VISUALIZATIONS_ENABLED variable and standardized boolean values to lowercase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| data-capture-type=""> | ||
| <i class="bi bi-graph-up me-1"></i>Visualize | ||
| </button> | ||
| {% if VISUALIZATIONS_ENABLED %} |
Copilot
AI
Dec 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VISUALIZATIONS_ENABLED setting needs to be made available to templates through a context processor. Currently, the templates reference this variable using {% if VISUALIZATIONS_ENABLED %}, but there's no context processor that exposes this setting. You should add a context processor in gateway/sds_gateway/context_processors.py that returns VISUALIZATIONS_ENABLED from the settings, similar to how allauth_settings is exposed in the users app.
No description provided.