Skip to content

Ensure that "The value '…' is not in a correct format" ends with a new line #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xced wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure that "The value '…' is not in a correct format" ends with a new line #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Spectre.Console.Cli.Tests/CommandAppTests.Pairs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public void Should_Throw_If_Value_Is_Not_In_A_Valid_Format_Using_Default_Deconst
string input, string expected)
{
// Given
var app = new CommandAppTester();
var app = new CommandAppTester { TestSettings = { TrimConsoleOutput = false } };
app.SetDefaultCommand<GenericCommand<DefaultPairDeconstructorSettings>>();

// When
Expand All @@ -203,7 +203,7 @@ public void Should_Throw_If_Value_Is_Not_In_A_Valid_Format_Using_Default_Deconst

// Then
result.ExitCode.ShouldBe(-1);
result.Output.ShouldBe(expected);
result.Output.ShouldBe(expected + Environment.NewLine);
}

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion src/Spectre.Console.Cli/CommandParseException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ internal static CommandParseException UnknownOption(IEnumerable<string> args, Co

internal static CommandParseException ValueIsNotInValidFormat(string value)
{
var text = $"[red]Error:[/] The value '[white]{value}[/]' is not in a correct format";
var text = $"[red]Error:[/] The value '[white]{value}[/]' is not in a correct format{Environment.NewLine}";
return new CommandParseException("Could not parse value", new Markup(text));
}

Expand Down