Skip to content

Conversation

@alesan99
Copy link
Contributor

@alesan99 alesan99 commented Dec 9, 2025

Fixes #7582

Warning

This PR affects database migrations. See migration testing instructions.
⚠️

Adds a new discipline types picklist.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Go to schema config -> Discipline
  • Make sure the type field is set to the new Discipline Types picklist
  • Make sure the picklist has all the discipline proper types
  • Dev Testing:
  • Run specify 0042_discipline_type_picklist migration
  • Revert the migration. Make sure the picklist was actually deleted.

@alesan99 alesan99 marked this pull request as ready for review December 10, 2025 14:56
@alesan99 alesan99 requested review from a team December 10, 2025 16:53
@alesan99 alesan99 added the Migration Prs that contain migration label Dec 10, 2025
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make sure the type field is set to the new Discipline Types picklist
  • Make sure the picklist has all the discipline proper types

There is no discipline type picklist so the field is also not set to a picklist. I did also briefly get a migration error upon first load but it went away and I cannot reproduce it so I am not sure if it's a problem or not.

Screenshot 2025-12-11 103232

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Dec 11, 2025
@alesan99
Copy link
Contributor Author

alesan99 commented Dec 12, 2025

There is no discipline type picklist so the field is also not set to a picklist. I did also briefly get a migration error upon first load but it went away and I cannot reproduce it so I am not sure if it's a problem or not.

@emenslin Hm I tried a copy of your database locally and the picklist migration ran. I'm not sure what a happened.

I did make changes to the code so hopefully it works now.

EDIT:
After trying it on the test panel I believe the issue is related to #7587

Once that PR is merged the migration should run.

@alesan99
Copy link
Contributor Author

@specify/ux-testing with #7587 merged, this PR is ready to test again! 👍

@alesan99 alesan99 requested a review from a team December 16, 2025 22:03
Triggered by 55f5353 on branch refs/heads/issue-7582
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Make sure the type field is set to the new Discipline Types picklist
  • Make sure the picklist has all the discipline proper types

I'm still running into the same issue I mentioned above, there is no Discipline Type picklist, however, I did not run into any migration errors this time.
image

Triggered by 811425b on branch refs/heads/issue-7582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Migration Prs that contain migration

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

Add Discipline types picklist migration

4 participants