Skip to content

Conversation

@Gitesh307
Copy link
Contributor

@Gitesh307 Gitesh307 commented Nov 11, 2025

Fixes #7537

This PR fixes Catalog Number Inheritance for Collection Object Groups so that new child COs no longer get auto-numbered when inheritance is enabled. The sibling API now resolves the primary catalog number using either a child_co_id or a cog_id, letting brand-new children (no id yet) inherit immediately. The COG “Add CO” dialog and catalog-number field component request the inherited value upfront and write it into the actual field value (not just a placeholder), while still allowing the user to edit it.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Verify in the UI that adding a child CO to a COG with
"catalogNumberInheritance": {
   "behavior": {
     "inheritance": true
   }}

now shows the primary CO’s catalog number as a grayout placeholder that can be manually edited.

@grantfitzsimmons
Copy link
Member

Research, unrelated to PR:

I checked out 68ffde7 (#6721), which was an old commit right after I tested that inheritance is working ("Verify the catalog number from the parent CO appears grayed out in the Component’s catalog number field")

In main:

image

In 68ffde7 (#6721):

image

I tried quite a number of times to get inheritance to work on both, using the following as my CollectionPreferences resource:

{"catalogNumberInheritance": {"behavior": {"inheritance": true}}}

Neither work. Not sure where it broke before. Will test this PR soon.

…tly and prevent parser placeholder from overriding inherited value
@Gitesh307 Gitesh307 reopened this Nov 17, 2025
Triggered by ae758c0 on branch refs/heads/issue-7537
@Gitesh307 Gitesh307 requested review from a team and melton-jason and removed request for a team November 17, 2025 19:58
@Gitesh307 Gitesh307 changed the title Fix : Enable Catalog Number Inheritance for COG Child COs Fix : Missing Catalog Number Placeholder for Inherited Values in Child COs Nov 19, 2025
@CarolineDenis CarolineDenis removed the request for review from melton-jason November 19, 2025 15:03
@CarolineDenis CarolineDenis requested review from a team and acwhite211 November 19, 2025 15:03
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify in the UI that adding a child CO to a COG with

Looks good
Screenshot 2025-11-19 133438

@emenslin emenslin requested a review from a team November 19, 2025 19:40
Copy link
Contributor

@Iwantexpresso Iwantexpresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify in the UI that adding a child CO to a COG with
"catalogNumberInheritance": {
   "behavior": {
     "inheritance": true
   }}

now shows the primary CO’s catalog number as a grayout placeholder that can be manually edited.

After adding the inheritance clause to the json file in app resources:

image

The new children of added to the COG are not properly inheriting the number form the primary number nor its being displayed as greyed out. and the auto numbering is still taking priority

image

@github-project-automation github-project-automation bot moved this from ✅Done to Dev Attention Needed in General Tester Board Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

Child CO Catalog Number Placeholder Not Rendering Inherited Value

7 participants