Skip to content

Conversation

@Gitesh307
Copy link
Contributor

@Gitesh307 Gitesh307 commented Oct 29, 2025

Fixes #7511

This PR restores the tree level picklist to its pre-regression behavior so editing existing tree nodes no longer triggers the browser’s “Please select an item in the list” error.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • open an existing non-root tree node, and confirm the Level field stays valid and Save button is not red anymore, other buttons stays enabled without re-selecting the rank.
  • verify that non-typeable behavior for tree level rank picklist is working.

@Gitesh307 Gitesh307 requested review from a team October 30, 2025 03:52
@Gitesh307 Gitesh307 added this to the 7.12.0 milestone Oct 30, 2025
Copy link
Contributor

@Iwantexpresso Iwantexpresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • open an existing non-root tree node, and confirm the Level field stays valid and Save button is not red anymore, other buttons stays enabled without re-selecting the rank.

  • just tested it and it looks good!

@CarolineDenis CarolineDenis requested a review from a team November 7, 2025 16:56
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • open an existing non-root tree node, and confirm the Level field stays valid and Save button is not red anymore, other buttons stays enabled without re-selecting the rank.

Looks good, buttons are no longer red!
image

@CarolineDenis
Copy link
Contributor

@Gitesh307, do you know when this code was changed and why?

@Gitesh307
Copy link
Contributor Author

@Gitesh307, do you know when this code was changed and why?

The change was introduced when I added the fix to disable manual typing in tree-level rank picklists issue #4985. That fix unintentionally treated _treeLevelComboBox like the others, which moved it to a simple dropdown and broke validation that depends on async data loading. So the condition was updated to exclude _treeLevelComboBox, letting it keep AutoComplete behavior and resolving the validation issue in #7524 .

@grantfitzsimmons grantfitzsimmons requested a review from a team November 12, 2025 17:22
@Gitesh307
Copy link
Contributor Author

The PR now initializes as valid and Save is enabled without allowing manual typing. Both validation and non-typeable behavior for tree level rank picklist (issue-4985) are intact.

@Gitesh307 Gitesh307 requested a review from emenslin November 13, 2025 04:28
@CarolineDenis CarolineDenis requested a review from a team November 19, 2025 19:54
Copy link

@kwhuber kwhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Open an existing non-root tree node, and confirm the Level field stays valid and Save button is not red anymore, other buttons stays enabled without re-selecting the rank.

I still face the error on various databases.

Screen.Recording.2025-12-05.at.1.18.48.PM.mov

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dev Attention Needed

Development

Successfully merging this pull request may close these issues.

Error with tree rank picklist

7 participants