Make symbolic serialization type-accurate and bijective by Copilot · Pull Request #2366 · spcl/dace

Copilot · 2026-05-12T17:19:00Z

Inspect latest CI failures and identify the remaining dtype-stripping pattern
Reproduce/trace typed-symbol and additive formatting behavior locally
Avoid constructing temporary default symbols while deserializing symbol($name, dtype=...)
Normalize additive negative rendering (+ -1 / +(-1*...) to subtraction)
Re-run focused serialization regressions under DACE_testing_serialization=1
Run final validation

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1e472f6e-62b2-4d7b-9d2a-9a3613bc9df8 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

tbennun

Looks great, but a few more changes and tests are required.

tbennun · 2026-05-12T17:54:59Z

+_SERIALIZED_TYPED_CONSTANT = re.compile(
+    rf'(?<![A-Za-z0-9_\.])(?P<value>{_SERIALIZED_TYPED_CONSTANT_VALUE})(?P<suffix>{_SERIALIZED_TYPED_CONSTANT_SUFFIX})\b'
+)
+_TYPECLASS_TO_LITERAL_SUFFIX = {


This should move to dtypes.py

Moved the typed-literal suffix metadata/helpers into dace.dtypes in 275da54.

tbennun · 2026-05-12T17:55:31Z



+class TypedConstant(sympy.AtomicExpr):
+    """A symbolic constant with an explicit DaCe data type."""


I am not sure what a "symbolic constant" is. This is a constant value used in a symbolic expression;

Add an example.

Clarified the TypedConstant docstring and added an explicit serialization example in 23f7e2f.

tbennun · 2026-05-12T17:59:43Z

+        return TypedConstant(expr, dtypes.float64)
+    if not isinstance(expr, str):
+        return expr
+    if expr == '?':


I would add a test for undefined symbols. Are they serialized as $? or ?? I would opt for the former.

Added undefined-symbol round-trip coverage and switched serialization to use $? in 275da54.

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ccc5069b-3a41-411b-a3fc-7ac4d373e5b1 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Agent-Logs-Url: https://github.com/spcl/dace/sessions/433e8b02-2ba6-4aca-9c25-cf3fd1f77802 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Agent-Logs-Url: https://github.com/spcl/dace/sessions/90f491eb-508c-4961-9084-e9c79a40c148 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Agent-Logs-Url: https://github.com/spcl/dace/sessions/893139c2-bf40-47b2-8768-81e3358bc8bc Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

tbennun

The latest round of changes are clearly a symptomatic fix for a deeper issue. That is also reflected by the fact that tests are still failing in CI.

The serialization/deserialization functions were already sound w.r.t. data types of symbols, so I suspect the issues are rooted within dace and the use of properties, as well as some invalid creation of new symbols with inappropriate dtypes happening somewhere in deserialization (otherwise, a serialize-deserialize-serialize roundtrip will always result in the same symbol type, regardless of whether it is an int32 $i or an int64 symbol($i, dtype=dace.int64). Please try again without special cases.

tbennun · 2026-05-13T22:44:23Z

    s_currentsymbol = 0

-    def __new__(cls, name=None, dtype=DEFAULT_SYMBOL_TYPE, **assumptions):
+    def __new__(cls, name=None, dtype=DEFAULT_SYMBOL_TYPE, explicit_dtype=True, **assumptions):


explicit_dtype is a bad argument. It should be very simple - if the dtype of the symbol is not DEFAULT_SYMBOL_TYPE, it should be printed out. Remove this argument.

Removed explicit_dtype and the related symbol-constructor plumbing in ff13b2b.

tbennun · 2026-05-13T22:45:41Z

+        def _label_str(val):
+            if issymbolic(val):
+                return dace.symbolic.serialize_symbolic(val).replace('$', '')
+            return str(val)
+
+        def _dim_to_string(dim):
+            if not isinstance(dim, tuple):
+                return _label_str(dim)
+            dres = _label_str(dim[0])
+            if dim[1] is not None:
+                if dim[1] - dim[0] != 0:
+                    off = 1
+                    if dim[2] is not None and (dim[2] < 0) == True:
+                        off = -1
+                    dres += ':' + _label_str(dim[1] + off)
+            if dim[2] != 1:
+                if dim[1] is None:
+                    dres += ':'
+                dres += ':' + _label_str(dim[2])
+            return dres
+
        return self.label + "[" + ", ".join(
-            ["{}={}".format(i, r)
-             for i, r in zip(self._params, [sbs.Range.dim_to_string(d) for d in self._range])]) + "]"
+            [f"{i}={r}" for i, r in zip(self._params, [_dim_to_string(d) for d in self._range])]) + "]"


Unnecessary change, please revert. Range.dim_to_string's behavior should stay unaffected by serialization.

Reverted the map label/stringification change in ff13b2b.

tbennun · 2026-05-13T22:46:27Z

+def _serialize_symbolic_with_converter(converter, value):
+    if not isinstance(value, (symbolic.SymExpr, sp.Basic)):
+        try:
+            value = _deserialize_symbolic_with_converter(converter, value)
+        except Exception:
+            pass
+    return symbolic.serialize_symbolic(value)


What is the purpose of this roundtrip?

Removed that helper roundtrip in ff13b2b. The fix now uses symbolic property types directly instead.

tbennun · 2026-05-13T22:48:49Z

@@ -1452,14 +1460,17 @@ def _binop_sub(a, b):
    @staticmethod
    def _binop_mul(a, b):
        if (_SerializedSymbolicParser._requires_preserved_structure(a)
-                or _SerializedSymbolicParser._requires_preserved_structure(b)):
+                or _SerializedSymbolicParser._requires_preserved_structure(b) or isinstance(a, sympy.Add)
+                or isinstance(b, sympy.Add)):
            return sympy.Mul(a, b, evaluate=False)
        return a * b

    @staticmethod
    def _binop_div(a, b):
        if (_SerializedSymbolicParser._requires_preserved_structure(a)
-                or _SerializedSymbolicParser._requires_preserved_structure(b)):
+                or _SerializedSymbolicParser._requires_preserved_structure(b)
+                or (isinstance(a, sympy.Mul) and any(isinstance(arg, sympy.Add)
+                                                     for arg in a.args)) or isinstance(b, sympy.Add)):


The special cases here seem to indicate that the serialization-deserialization-serialization is inconsistent. These might not be the last special cases and this concerns me. Is there a simpler way to always disable evaluate so that we don't have to special case distributive rules etc.?

Replaced the ad hoc operator special cases with a generic non-evaluating symbolic parse in ff13b2b.

tbennun · 2026-05-13T22:50:10Z

+        return '*'.join(parts) if parts else '1'
+

-@lru_cache(maxsize=16384)


please return this line

Tracked this down to same-name symbol serialization collisions; ff13b2b fixes the root cause without reintroducing the previous symptomatic behavior.

tbennun · 2026-05-13T22:51:15Z

+    if dtypes.validate_name(expr):
+        return symbol(expr)


This means that we will deserialize a symbol by name even if it is not in the standard serialized format. This is wrong. Please revert this. I think this is a symptom of an issue somewhere else, and this is not the right way to solve it.

Reverted the name-based deserialize fallback in ff13b2b.

tbennun · 2026-05-13T22:51:42Z

+def test_inferred_symbol_dtype_is_not_serialized():
+    inferred = symbolic.symbol('i', dtype=dace.int64, explicit_dtype=False)
+
+    assert symbolic.serialize_symbolic(inferred) == '$i'


Remove this test as it is wrong!

Removed that test in ff13b2b.

tbennun · 2026-05-13T22:54:50Z

+def test_list_property_pystr_to_symbolic_json_roundtrip_supports_plain_names():
+    prop = ListProperty(element_type=symbolic.pystr_to_symbolic)
+
+    assert prop.to_json(['START']) == ['$START']
+
+    restored = prop.from_json(['START'])
+
+    assert len(restored) == 1
+    assert restored[0] == symbolic.symbol('START')
+
+
+def test_dict_property_pystr_to_symbolic_json_roundtrip_supports_plain_names():
+    prop = DictProperty(key_type=str, value_type=symbolic.pystr_to_symbolic)
+
+    assert prop.to_json({'N': 'N'}) == {'N': '$N'}
+
+    restored = prop.from_json({'N': 'N'})
+
+    assert restored == {'N': symbolic.symbol('N')}
+
+


It seems to me that the error that caused these two tests is the element_type/value_type being wrongly assigned to a function. I would encourage finding a better solution for lists of symbolic expressions, as well as dicts with symbolic keys/values. Subsequently, remove all the cases where users used {element,key,value}_type=pystr_to_symbolic. Maybe the special case in properties.py should be "if the type is a subclass of/equal to sympy.Basic or set to symbolic.SymbolicType or is a subclass of/equal to SymExpr"

Changed the symbolic list/dict properties to use real symbolic types (sympy.Basic) and removed the pystr_to_symbolic property declarations in ff13b2b.

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1dc8b311-87d3-4b93-9a7a-edc47d144171 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot · 2026-05-13T23:18:51Z

The latest round of changes are clearly a symptomatic fix for a deeper issue. That is also reflected by the fact that tests are still failing in CI.

The serialization/deserialization functions were a...

Reworked this around the underlying causes in ff13b2b: removed the serializer/deserializer special cases, switched symbolic properties to real symbolic types, stopped inferring non-default iterator/index symbol dtypes in the frontend, and kept the affected DACE_testing_serialization=1 regression slice green.

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1dc8b311-87d3-4b93-9a7a-edc47d144171 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Agent-Logs-Url: https://github.com/spcl/dace/sessions/90e03a82-7b38-4393-8cb8-e753956a138d Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Initial plan

b6fb40c

Copilot AI assigned Copilot and tbennun May 12, 2026

Copilot started work on behalf of tbennun May 12, 2026 17:19 View session

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request

Type-Accurate and Reproducible Symbolic Expression Serialization #2365

Open

Copilot AI and others added 6 commits May 12, 2026 17:34

feat: preserve symbolic serialization metadata

27ebe54

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1e472f6e-62b2-4d7b-9d2a-9a3613bc9df8 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: address review feedback on symbolic serialization

2e1a2db

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1e472f6e-62b2-4d7b-9d2a-9a3613bc9df8 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

docs: clarify symbolic converter helpers

4da775f

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1e472f6e-62b2-4d7b-9d2a-9a3613bc9df8 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: document symbolic serialization edge cases

f3a04d2

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1e472f6e-62b2-4d7b-9d2a-9a3613bc9df8 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: improve typed literal parser diagnostics

ae5886f

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1e472f6e-62b2-4d7b-9d2a-9a3613bc9df8 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: refine symbolic serializer helpers

4449080

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1e472f6e-62b2-4d7b-9d2a-9a3613bc9df8 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add type-accurate serialization for symbolic expressions~~ Make symbolic serialization type-accurate and bijective May 12, 2026

Copilot AI requested a review from tbennun May 12, 2026 17:40

Copilot finished work on behalf of tbennun May 12, 2026 17:40

tbennun requested changes May 12, 2026

View reviewed changes

Copilot started work on behalf of tbennun May 12, 2026 18:00 View session

Copilot AI and others added 5 commits May 12, 2026 18:07

feat: add typed literal follow-up fixes

275da54

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ccc5069b-3a41-411b-a3fc-7ac4d373e5b1 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

docs: clarify typed literal helpers

23f7e2f

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ccc5069b-3a41-411b-a3fc-7ac4d373e5b1 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: polish typed literal follow-up

38706e1

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ccc5069b-3a41-411b-a3fc-7ac4d373e5b1 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: finish symbolic literal cleanup

1de18fd

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ccc5069b-3a41-411b-a3fc-7ac4d373e5b1 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: narrow float cpp literal handling

7b2dbd2

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ccc5069b-3a41-411b-a3fc-7ac4d373e5b1 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot finished work on behalf of tbennun May 12, 2026 18:12

Copilot AI requested a review from tbennun May 12, 2026 18:12

tbennun approved these changes May 12, 2026

View reviewed changes

tbennun marked this pull request as ready for review May 12, 2026 18:15

tbennun requested a review from ThrudPrimrose May 12, 2026 18:16

Copilot started work on behalf of tbennun May 12, 2026 18:33 View session

Copilot AI and others added 3 commits May 12, 2026 18:45

fix: stabilize serialization roundtrips

531cd4f

Agent-Logs-Url: https://github.com/spcl/dace/sessions/433e8b02-2ba6-4aca-9c25-cf3fd1f77802 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

fix: canonicalize serialization roundtrips

0d95cc9

Agent-Logs-Url: https://github.com/spcl/dace/sessions/433e8b02-2ba6-4aca-9c25-cf3fd1f77802 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: polish serialization validation fixes

b6ff3db

Agent-Logs-Url: https://github.com/spcl/dace/sessions/433e8b02-2ba6-4aca-9c25-cf3fd1f77802 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot AI and others added 7 commits May 12, 2026 19:13

fix: preserve symbolic roundtrip structure

bbb4c34

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: restore array-safe default serialization check

938f859

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: simplify symbolic parser operator table

6ae82a0

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: preserve default comparison compatibility

91b0d2d

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: document default deep copy behavior

3314da1

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: use sympy boolean identity checks

7d342e8

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

test: cover plain integer symbolic roundtrips

877e787

Agent-Logs-Url: https://github.com/spcl/dace/sessions/ad1f4362-f591-4cf9-84d0-d89dc605a6a9 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot finished work on behalf of tbennun May 12, 2026 19:22

Copilot started work on behalf of tbennun May 12, 2026 20:56 View session

Copilot AI and others added 2 commits May 12, 2026 21:05

fix: avoid preserving non-typed symbolic AST structure

8b39325

Agent-Logs-Url: https://github.com/spcl/dace/sessions/90f491eb-508c-4961-9084-e9c79a40c148 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: align modulo parser fallback

bc8add3

Agent-Logs-Url: https://github.com/spcl/dace/sessions/90f491eb-508c-4961-9084-e9c79a40c148 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot finished work on behalf of tbennun May 12, 2026 21:08

tbennun approved these changes May 13, 2026

View reviewed changes

Copilot started work on behalf of tbennun May 13, 2026 05:41 View session

Copilot AI and others added 3 commits May 13, 2026 06:09

fix: normalize symbolic property roundtrips

0a8d2f3

Agent-Logs-Url: https://github.com/spcl/dace/sessions/893139c2-bf40-47b2-8768-81e3358bc8bc Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: address symbolic serializer review feedback

eecdff6

Agent-Logs-Url: https://github.com/spcl/dace/sessions/893139c2-bf40-47b2-8768-81e3358bc8bc Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: polish symbolic mul serializer formatting

5d1683c

Agent-Logs-Url: https://github.com/spcl/dace/sessions/893139c2-bf40-47b2-8768-81e3358bc8bc Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot finished work on behalf of tbennun May 13, 2026 06:15

Copilot AI requested a review from tbennun May 13, 2026 06:15

tbennun requested changes May 13, 2026

View reviewed changes

Copilot started work on behalf of tbennun May 13, 2026 22:59 View session

fix: address symbolic serialization root causes

ff13b2b

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1dc8b311-87d3-4b93-9a7a-edc47d144171 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: handle multiplicative identity edge cases

04b3765

Agent-Logs-Url: https://github.com/spcl/dace/sessions/1dc8b311-87d3-4b93-9a7a-edc47d144171 Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot finished work on behalf of tbennun May 13, 2026 23:21

Copilot AI requested a review from tbennun May 13, 2026 23:21

Copilot started work on behalf of tbennun May 14, 2026 21:29 View session

Copilot AI and others added 2 commits May 14, 2026 21:40

fix: preserve symbol dtype during deserialization

5590560

Agent-Logs-Url: https://github.com/spcl/dace/sessions/90e03a82-7b38-4393-8cb8-e753956a138d Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

chore: support SymPy numeric predicates in serializer

a5c4489

Agent-Logs-Url: https://github.com/spcl/dace/sessions/90e03a82-7b38-4393-8cb8-e753956a138d Co-authored-by: tbennun <8348955+tbennun@users.noreply.github.com>

Copilot finished work on behalf of tbennun May 14, 2026 21:42



		class TypedConstant(sympy.AtomicExpr):
		"""A symbolic constant with an explicit DaCe data type."""

		return '*'.join(parts) if parts else '1'


		@lru_cache(maxsize=16384)

Conversation

Copilot AI commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbennun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 12, 2026

Choose a reason for hiding this comment

Uh oh!

tbennun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented May 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 12, 2026 •

edited

Loading