Allow users to require mocks in tests with Spawnia\Sailor\Testing\RequiresSailorMocks
#120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quiresSailorMocks`
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new trait, RequiresSailorMocks, along with the requireMocks() method to enforce mock usage in tests and prevent stray requests.
- Updated README.md with new installation and testing instructions using RequiresSailorMocks
- Refactored code examples to use named arguments and variables for improved clarity
- Updated CHANGELOG.md to reflect the new additions
Reviewed Changes
Copilot reviewed 2 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Updated installation instructions and test integration examples using the new trait and method |
| CHANGELOG.md | Added changelog entries for the new trait and method |
Files not reviewed (7)
- src/Operation.php: Language not supported
- src/Testing/RequiresSailorMocks.php: Language not supported
- tests/Integration/CustomTypesTest.php: Language not supported
- tests/Integration/InputTest.php: Language not supported
- tests/Integration/PolymorphicTest.php: Language not supported
- tests/Integration/SimpleTest.php: Language not supported
- tests/Unit/Testing/RequiresSailorMocksTest.php: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Spawnia\Sailor\Testing\RequiresSailorMocksSpawnia\Sailor\Operation::requireMocks()Breaking changes
None, I thought about integrating this in
Spawnia\Sailor\Testing\UsesSailorMocksbut saw that it broke our tests and may break some integration tests others have.