docs: document how to add a new language#16
Merged
spathon merged 4 commits intospathon:mainfrom Mar 5, 2026
Merged
Conversation
Adds a short guide explaining how to add a new locale, including required changes in context.tsx and types.ts. References the commit that introduced the pt locale as an example. On branch docs/add-language-guide Changes to be committed: modified: README.md
Owner
|
That's a good idea! export const SUPPORTED_LOCALES = ['en', 'es', 'fr', 'de', 'sv', 'pt'] as const
export const LOCALES = {
...
pt: 'Português',
}Maybe use the changes url (https://github.com/spathon/Visual-JOIN/pull/15/changes) instead of commit as Locale was changed to SUPPORTED_LOCALES |
Adjust the README guide for adding new languages after the i18n simplification. Removes the step requiring changes in context.tsx and updates the reference link to the PR that introduced the Portuguese locale. On branch docs/add-language-guide Your branch is up to date with 'origin/docs/add-language-guide'. Changes to be committed: modified: README.md
Contributor
Author
|
Thanks! Nice improvement. I will update the README to reflect the simplified flow (no need to modify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a short guide explaining how to add a new locale, using the pt implementation as reference.