Skip to content

go: move build envs from builder into Go pkg #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
becker33 merged 2 commits into from
Mar 20, 2026
Merged

go: move build envs from builder into Go pkg #3896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5f31aa
go: move build envs from builder into Go pkg
alecbcs Mar 18, 2026
8bb369b
Remove unused join_path import
alecbcs Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions repos/spack_repo/builtin/build_systems/go.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
depends_on,
execute_install_time_tests,
install,
join_path,
mkdirp,
register_builder,
run_after,
Expand Down Expand Up @@ -104,9 +103,6 @@ def check_args(self):

def setup_build_environment(self, env: EnvironmentModifications) -> None:
env.set("CGO_ENABLED", "1" if self.cgo_enabled else "0")
env.set("GO111MODULE", "on")
env.set("GOTOOLCHAIN", "local")
env.set("GOPATH", join_path(self.pkg.stage.path, "go"))

def build(self, pkg: GoPackage, spec: Spec, prefix: Prefix) -> None:
"""Runs ``go build`` in the source directory"""
Expand Down
6 changes: 6 additions & 0 deletions repos/spack_repo/builtin/packages/go/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@ def install(self, spec, prefix):
install_tree(".", prefix.go)
symlink(prefix.go.bin, prefix.bin)

def setup_dependent_build_environment(self, env, dependent_spec):
env.set("GO111MODULE", "on")
env.set("GOTOOLCHAIN", "local")
env.set("GOMAXPROCS", str(make_jobs))
env.set("GOPATH", join_path(dependent_spec.package.stage.path, "go"))

def setup_dependent_package(self, module, dependent_spec):
"""Called before go modules' build(), install() methods.

Expand Down
Loading