Windows Gitlab CI: Explicitly override image entrypoint#3887
Merged
scheibelp merged 1 commit intospack:developfrom Mar 19, 2026
Merged
Windows Gitlab CI: Explicitly override image entrypoint#3887scheibelp merged 1 commit intospack:developfrom
scheibelp merged 1 commit intospack:developfrom
Conversation
By default, all docker image entrypoints are overridden for CI runs on Gitlab as configured by the `default:image:override` setting in the base gitlab-ci yaml. When overriding part of an image definition in a job definition, gitlab will throw away the non overriden component as well. Windows specifies a specific docker image, and in doing so, removes the entrypoint override. This is fine for our cloud hosted runners as kube overrides the entrypoint itself. Docker+machine runners however will respect the non overridden entrypoint. Explicitly override the entrypoint in our Windows CI config to bring Windows stacks in line with the rest of Spack's stacks. Adds an explicit entrypoint override to the CI config image override for Windows generate and build jobs. Signed-off-by: John Parent <john.parent@kitware.com>
johnwparent
requested review from
kwryankrattiger and
zackgalbreath
as code owners
Contributor
Author
|
@zackgalbreath @eugeneswalker I spun out the fix from the UO test branch and added the fix to the build jobs as well. |
zackgalbreath
approved these changes
Mar 18, 2026
kwryankrattiger
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, all docker image entrypoints are overridden for CI runs on Gitlab as configured by the
default:image:overridesetting in the base gitlab-ci yaml. When overriding part of an image definition in a job definition, gitlab will throw away the non overriden component as well. Windows specifies a specific docker image, and in doing so, removes the entrypoint override. This is fine for our cloud hosted runners as kube overrides the entrypoint itself. Docker+machine runners however will respect the non overridden entrypoint.Explicitly override the entrypoint in our Windows CI config to bring Windows stacks in line with the rest of Spack's stacks.
Adds an explicit entrypoint override to the CI config image override for Windows generate and build jobs.
Fix spun out from #3843