nccl, aws-ofi-nccl: add new versions and add rocm support to aws-ofi-nccl#3885
Draft
msimberg wants to merge 11 commits intospack:developfrom
Draft
nccl, aws-ofi-nccl: add new versions and add rocm support to aws-ofi-nccl#3885msimberg wants to merge 11 commits intospack:developfrom
msimberg wants to merge 11 commits intospack:developfrom
Conversation
spackbot-triage
bot
added
new-version
dependencies
update-package
conflicts
new-variant
labels
albestro
reviewed
Mar 18, 2026
| version("1.7.1", sha256="d50a160c7aba76445e5c895fba0f3dbfdec51f702d218168a5e5017806cf0fb0") | ||
| version("1.6.0", sha256="19a6fc91afe9a317fd3154c897fa219eab48fcdddefa66d881f1843c1165f7ee") | ||
|
|
||
| variant("cuda", default=True, description="Enable CUDA support") |
Contributor
There was a problem hiding this comment.
is there any reason for not making this a CudaPackage/ROCmPackage?
Contributor
Author
There was a problem hiding this comment.
No, I'm glad you asked. It just didn't cross my mind... Let me try to make that change.
msimberg
commented
Mar 18, 2026
| depends_on("cuda", when="+cuda") | ||
| depends_on("nccl fabrics=auto", when="+cuda") | ||
| depends_on("hip", when="+rocm") | ||
| depends_on("rccl", when="+rocm") |
Contributor
Author
There was a problem hiding this comment.
I should actually check if this is needed since --with-rccl isn't needed...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.18.0 aws-ofi-nccl has support for rocm (aws/aws-ofi-nccl#1014). This effectively replaces aws-ofi-rccl. Note that
--with-rcclis not needed.--with-ncclcould possibly also be removed, but I have not tested that change so leaving it out from here.