Fix healpix_cxx package for 3 digit cfitsio versions and add version 1.19 for py-healpy#3873
Open
KiSchnelle wants to merge 4 commits intospack:developfrom
Open
Fix healpix_cxx package for 3 digit cfitsio versions and add version 1.19 for py-healpy#3873KiSchnelle wants to merge 4 commits intospack:developfrom
KiSchnelle wants to merge 4 commits intospack:developfrom
Conversation
wdconinc
reviewed
Apr 12, 2026
Contributor
wdconinc
left a comment
wdconinc
left a comment
There was a problem hiding this comment.
Thanks for these contributions. Some comments.
| spec["libsharp"].prefix.lib | ||
| ), | ||
| ) | ||
| # Fix cfitsio version check broken by 3-part version numbers |
Contributor
There was a problem hiding this comment.
Did the two-component releases of cfitsio define the MAJOR/MINOR macros? Does this filter_file need to be gated on cfitsio version too?
|
|
||
| homepage = "https://healpy.readthedocs.io/" | ||
| pypi = "healpy/healpy-1.13.0.tar.gz" | ||
| pypi = "healpy/healpy-1.19.0.tar.gz" |
Contributor
There was a problem hiding this comment.
FYI These changes are not necessary when adding versions. Spack derives patterns from this.
| depends_on("c", type="build") # generated | ||
| depends_on("cxx", type="build") # generated | ||
| depends_on("fortran", type="build") # generated | ||
| depends_on("c", type="build") |
Contributor
There was a problem hiding this comment.
Is C needed (and was it before)? setup.py declares languages c++ only.
| depends_on("py-cython", type="build", when="@1.15:") | ||
|
|
||
| depends_on("py-numpy@1.13:1", type=("build", "run"), when="@:1.14") | ||
| depends_on("py-numpy@1.13:", type=("build", "run"), when="@1.15:") |
Contributor
There was a problem hiding this comment.
At least right now this needs numpy 1.19 or newer. Can you verify the dependencies?
| # Fix cfitsio version check for 3-part versions | ||
| fitshandle = FileFilter("healpixsubmodule/src/cxx/cxxsupport/fitshandle.cc") | ||
| fitshandle.filter( | ||
| r"int v_header\s*=\s*nearest<int>\(1000\.\*CFITSIO_VERSION\)", |
| depends_on("fortran", type="build") | ||
|
|
||
| depends_on("py-setuptools@3.2:", type="build") | ||
| depends_on("python@:3.10", when="@:1.14") |
Contributor
There was a problem hiding this comment.
The complementary minimum python versions are missing, i.e. 3.10 for 1.19.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.