fix: correct ingest file upload endpoint URL#530
Merged
jamiepine merged 1 commit intospacedriveapp:mainfrom Apr 4, 2026
Merged
fix: correct ingest file upload endpoint URL#530jamiepine merged 1 commit intospacedriveapp:mainfrom
jamiepine merged 1 commit intospacedriveapp:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated the API endpoint URL for file uploads from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jamiepine
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uploadIngestFilesfunction was POSTing to/agents/ingest/upload, but the backend handler (upload_ingest_file) is registered at/agents/ingest/files— causing a silent 404 and "Upload failed" in the UI.Verification
#[utoipa::path(post, path = "/agents/ingest/files", ...)]insrc/api/ingest.rs:113routes!(ingest::upload_ingest_file)insrc/api/server.rs:155schema.d.ts) has no/agents/ingest/uploadpath — confirms only/agents/ingest/filesexists