Quarantine structural instruction reads#310
Merged
Merged
Conversation
The reader-axis taint-FLOW layer (instructionTaintedNames/Fields, readsTaintedField, lvalueName, isStringyType, the transitive reader fixpoint, and the name-taint branches of exprInstructionTainted) plus the reader-axis planted-control tests (TestSweepDetectsEvasionShapes / TestHostneutralitySweepDetectsEvasionShapes and the assertRedThenGreen helpers, the multi-hop fixpoint cases) are removed. The sweep keeps the match-axis core: the named-reader allowlist, the recognized path-ident allowlist, the direct-read predicate (a read sink whose path arg carries a recognized instruction literal/segment/var, or a WalkDir .md collector) and the mutation control. A per-package go/ast scan structurally cannot see a cross-package read or a path built in another file, so the reader axis is documented as detached-adversarial-audit-backstopped (sweep docstrings + the validation-stage policy), not statically guarded. Per-file net-negative: HN 731->407 (-324), integration 794->430 (-364). Offline go test ./... green (1164 passed); workflow contract VALID. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
clkao
added a commit
that referenced
this pull request
Jun 6, 2026
clkao
added a commit
that referenced
this pull request
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/contractlintbehind a thin boundary guardValidation
go test ./internal/contractlint= 11 passedgo test ./internal/hostneutrality ./skills/integration ./internal/contractlint= 20 passedspacedock status --workflow-dir docs/dev --validate= VALIDgo test ./...= 1117 passed in 16 packagesgo test ./... -race= 1117 passed in 16 packagesRebase note
Rebased onto
origin/nextafter #300. The only conflict wasskills/integration/skill_surface_test.go: #300 added more legacymarkNonACPi instruction prose lints to a file this branch deletes. Resolved by preserving the delete because those checks belong to the class this task removes or quarantines.Workflow state:
docs/dev/.spacedock-state/sweep-guard-reader-axis-invert/index.md.