feat(ensign): add commit-before-idle and anti-idle rules#135
Merged
Conversation
Collaborator
|
@iamcxa Thanks! This PR contains other changes, can you split them and update the PR with clean FO/Ensign rules? |
This was referenced Apr 20, 2026
22bc0b9 to
36620b8
Compare
Contributor
Author
|
Done — rebased onto
1 commit, 1 file touched ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensigns that go idle without committing require FO nudges — up to 3 per session observed in practice. This PR adds two explicit rules to ensign-shared-core to prevent this failure mode.
What changed
Review guidance
These rules are derived from operational experience: the failure mode was 'ensign signals done, FO checks entity file, no commit, must re-dispatch.' The rules make the commit requirement explicit rather than implied by the Completion section.