XamlX SreTypeSystem: Allow internal types#2
Draft
nyeogmi wants to merge 2 commits into
Draft
Conversation
This is a hack I gave Dr. Smugleaf -- it unbreaks resolution of types like ProfSettings. I can tool this into something more useful _and_ saner if this is an implementation approach the SS14 dev team wants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This draft is split over two repos. The engine part, which includes an explanation, is here.)
Likely a prod-ready implementation of this would actually copy SreTypeSystem into a new RobustSreTypeSystem class inside the game code, because changing library internals is grody. But that would be a massively bloated change in comparison to this proof-of-concept.