Conversation
fix ReflectionClass::getClass deprecated (php8)
|
damn we should use a github actions ci if we really want to maintain this, did you run the tests? |
|
Woops I did not saw that there was a Travis CI! I just copied my PR on behatch here. I will look at this maybe tomorrow! |
|
@soyuka OK I understand your message now ! The This PR is a clone of Behatch#262 , where the CI did pass. It seems that your fork did not change that much, so CI should pass 🤞 . If you want to merge this, and the CI does fail after fixing selenium, ping me and I will correct it if you want. |
|
I'll move the CI at some point |
|
actually: #2 haha need to make this work |
Thanks for the effort of forking behatch/contexts.
As behatch/context is unmaintained, I open the same PR I did there.
This pull request improves the error message, by telling which node is failing, the actual content and the expected value.
For the record, we use this at Mapado on my fork since 2018, and we find it way better with those messages.
Before (fail on first error, no hint about which line does fail):

With PR:
