fix(ios): use precise time tolerance for thumbnail generation#142
Open
Kavakliyski wants to merge 1 commit intosouvik-ghosh:masterfrom
Open
fix(ios): use precise time tolerance for thumbnail generation#142Kavakliyski wants to merge 1 commit intosouvik-ghosh:masterfrom
Kavakliyski wants to merge 1 commit intosouvik-ghosh:masterfrom
Conversation
Set precise time tolerance for image generation to avoid snapping to keyframes. Sets `requestedTimeToleranceBefore` and `requestedTimeToleranceAfter` to `kCMTimeZero` to ensure thumbnails are generated at the exact requested timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets
requestedTimeToleranceBeforeandrequestedTimeToleranceAftertokCMTimeZeroto ensure thumbnails are generated at the exact requested timestamp.
Problem
Without explicit tolerance settings, AVAssetImageGenerator snaps to the nearest
keyframe, which can result in thumbnails from significantly different timestamps
than requested.
Solution
Configure zero tolerance to force precise frame extraction.