Conversation
* enabled xtrabackup specific percona repo for el10 Signed-off-by: Tiffany Chang <tiffkc525@gmail.com>
| supports 'debian' | ||
| supports 'redhat' | ||
| supports 'ubuntu' | ||
| supports 'almalinux' |
There was a problem hiding this comment.
@ramereth this was how I ended up testing with almalinux instances on openstack to get around my issues with dokken, I'll be removing this line after further testing but I wanted to point this out and ask if there's a better way to go about it since I'm not sure if this is good practice.
| # ver = version.tr('.', '') | ||
| # describe package 'percona-server-devel' do | ||
| # it { should be_installed } | ||
| #end |
There was a problem hiding this comment.
I'm also a bit unsure if this test case is supposed to be here since devel packages aren't installed by default
| gpgcheck node['percona']['yum']['gpgcheck'] | ||
| sslverify node['percona']['yum']['sslverify'] | ||
| end | ||
| end |
There was a problem hiding this comment.
Also, I was wondering if the xtrabackup should only be enabled when the xtrabackup is package should be downloaded? The way I currently have it set up is that it's automatically enabled on any rhel os version over 10.
There was a problem hiding this comment.
I don't follow, can you please elaborate?
There was a problem hiding this comment.
I was wondering if the xtrabackup repo should be enabled only when default['percona']['backup']['configure'] is true and disabled otherwise because that would be the only time this repo needs to be enabled.
ramereth
left a comment
ramereth
left a comment
There was a problem hiding this comment.
Can you also please fix the markdown issues in the Changelog so the CI will run?
| # ver = version.tr('.', '') | ||
| # describe package 'percona-server-devel' do | ||
| # it { should be_installed } | ||
| # end |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
I mentioned this in an earlier comment but ['percona']['client']['install_devel_package'] is false by default so this test was failing, I just wanted to confirm if it should be removed before I took it out so I had it commented out for now.
2 participants
Description
Describe what this change achieves.
Issues Resolved
List any existing issues this PR resolves.
Check List
fix: resolve bug in resource,feat: add new property,docs: update READMEDO NOT manually edit these files:
metadata.rbversion - Managed by release-pleaseCHANGELOG.md- Auto-generated from conventional commitsThe release process:
Need help? See Conventional Commits guide