Orbis module#113
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #113 +/- ##
==========================================
+ Coverage 47.90% 48.16% +0.26%
==========================================
Files 276 301 +25
Lines 16200 17423 +1223
==========================================
+ Hits 7760 8392 +632
- Misses 7640 8174 +534
- Partials 800 857 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| proto: | ||
| ignite generate proto-go | ||
| PATH="$$(go env GOPATH)/bin:$$PATH" buf generate proto --template proto/buf.gen.pulsar.yaml | ||
| ignite generate proto-go --yes |
There was a problem hiding this comment.
This is because
The default Pulsar generation path currently does not handle these proto3 optional fields correctly. When protoc-gen-go-pulsar generated API files for:
and I need the optional field since this is ideomatic rust and my types were designed in rust
That gives us valid API .pb.go files for Orbis while keeping the existing Pulsar path for everything else.
* Add node info to orbis module * tests * add grpc node info endpoint * coderabbit
This removes the orbis specific code from bulletin and creates an orbis specific module with a lot more "opinions" about data structure