Skip to content

Orbis module#113

Draft
JesseAbram wants to merge 7 commits into
devfrom
jesse/Orbis-module
Draft

Orbis module#113
JesseAbram wants to merge 7 commits into
devfrom
jesse/Orbis-module

Conversation

@JesseAbram
Copy link
Copy Markdown
Contributor

This removes the orbis specific code from bulletin and creates an orbis specific module with a lot more "opinions" about data structure

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: aaa4a875-3252-4a97-98ba-c45137892b49

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 19, 2026

Codecov Report

❌ Patch coverage is 47.21435% with 559 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.16%. Comparing base (d5fe809) to head (ad1a75a).
⚠️ Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
x/orbis/keeper/msg_server.go 55.11% 76 Missing and 25 partials ⚠️
x/orbis/keeper/grpc_query.go 0.00% 94 Missing ⚠️
x/orbis/keeper/validation.go 21.69% 76 Missing and 7 partials ⚠️
x/orbis/keeper/store.go 56.89% 50 Missing ⚠️
x/orbis/types/message_store_document.go 0.00% 24 Missing ⚠️
x/orbis/types/message_store_key_derivation.go 0.00% 21 Missing ⚠️
x/orbis/module/genesis.go 5.00% 14 Missing and 5 partials ⚠️
x/orbis/types/message_create_ring.go 0.00% 19 Missing ⚠️
x/orbis/keeper/acp.go 0.00% 17 Missing ⚠️
x/orbis/module/module.go 71.42% 14 Missing and 2 partials ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #113      +/-   ##
==========================================
+ Coverage   47.90%   48.16%   +0.26%     
==========================================
  Files         276      301      +25     
  Lines       16200    17423    +1223     
==========================================
+ Hits         7760     8392     +632     
- Misses       7640     8174     +534     
- Partials      800      857      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread Makefile
proto:
ignite generate proto-go
PATH="$$(go env GOPATH)/bin:$$PATH" buf generate proto --template proto/buf.gen.pulsar.yaml
ignite generate proto-go --yes
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because

The default Pulsar generation path currently does not handle these proto3 optional fields correctly. When protoc-gen-go-pulsar generated API files for:

and I need the optional field since this is ideomatic rust and my types were designed in rust

That gives us valid API .pb.go files for Orbis while keeping the existing Pulsar path for everything else.

* Add node info to orbis module

* tests

* add grpc node info endpoint

* coderabbit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants