-
Notifications
You must be signed in to change notification settings - Fork 27
Update to flapdoodle.embed.mongo 4.x #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ydylla
wants to merge
15
commits into
sourcemuse:master
Choose a base branch
from
ydylla:update
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did not work anymore and the default flapdoodle one works fine too
Author
|
I also had to lower the jdk requirement since some of our projects still use jdk 11. |
Author
|
Hi @roberttaylor426, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR updates the plugin to use de.flapdoodle.embed.mongo 4.4.0.
Which should enable the usage of mongodb 6 (not tested) and recent operating system like Linux Mint 21.1.
I think all options except
downloadUrlare backwards compatible with previous plugin versions.downloadUrlnow is only the base download url, because I could not figure out how to configure the exact download url. The only available docs for flapdoodle 4.x seam to be this Howto.md. Do you think base url is good enough or should it really be an exact url? I never used thedownloadUrloption.