Skip to content

Repository-wide correctness review#2478

Merged
jviotti merged 5 commits into
mainfrom
core-review
Jun 10, 2026
Merged

Repository-wide correctness review#2478
jviotti merged 5 commits into
mainfrom
core-review

Conversation

@jviotti

@jviotti jviotti commented Jun 10, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: b972df0 Previous: a75b850 Ratio
GZIP_Compress_ISO_Language_Set_3_Locations 39212405.61111163 ns/iter 37556936.05555482 ns/iter 1.04
GZIP_Decompress_ISO_Language_Set_3_Locations 4044261.040462516 ns/iter 4675346.216216084 ns/iter 0.87
GZIP_Compress_ISO_Language_Set_3_Schema 2286430.800653593 ns/iter 2045338.020348866 ns/iter 1.12
GZIP_Decompress_ISO_Language_Set_3_Schema 276501.53720359976 ns/iter 396577.22675736435 ns/iter 0.70
HTML_Build_Table_100000 69634628.00000003 ns/iter 58545422.16666895 ns/iter 1.19
HTML_Render_Table_100000 2007886.06340065 ns/iter 1821081.603674515 ns/iter 1.10
JSONL_Parse_Large 15372256.127659027 ns/iter 16078183.837209487 ns/iter 0.96
JSONL_Parse_Large_GZIP 16555943.404761191 ns/iter 17568664.399999537 ns/iter 0.94
URITemplateRouter_Create 30194.568919501235 ns/iter 31074.468993275932 ns/iter 0.97
URITemplateRouter_Match 161.2418362873108 ns/iter 163.51919398830276 ns/iter 0.99
URITemplateRouter_Match_BasePath 186.8263986622762 ns/iter 185.56459124681703 ns/iter 1.01
URITemplateRouterView_Restore 8718.695088952385 ns/iter 7801.647171589071 ns/iter 1.12
URITemplateRouterView_Match 126.30370308578371 ns/iter 126.12615911838017 ns/iter 1.00
URITemplateRouterView_Match_BasePath 142.66126421876274 ns/iter 141.60483742635074 ns/iter 1.01
URITemplateRouterView_Arguments 451.6159489620905 ns/iter 475.28076462996785 ns/iter 0.95
Pointer_Object_Traverse 34.201199581445636 ns/iter 34.045947882039904 ns/iter 1.00
Pointer_Object_Try_Traverse 22.57745233712252 ns/iter 22.162668595952304 ns/iter 1.02
Pointer_Push_Back_Pointer_To_Weak_Pointer 169.37904054841684 ns/iter 148.08796085092789 ns/iter 1.14
Pointer_Walker_Schema_ISO_Language 2064218.2379679997 ns/iter 3328603.886255641 ns/iter 0.62
Pointer_Maybe_Tracked_Deeply_Nested/0 1861600.3899204654 ns/iter 1898522.6280325036 ns/iter 0.98
Pointer_Maybe_Tracked_Deeply_Nested/1 1837143.9790025833 ns/iter 1886707.7640752713 ns/iter 0.97
Pointer_Position_Tracker_Get_Deeply_Nested 679.0839118515158 ns/iter 507.1926164478847 ns/iter 1.34
JSON_Array_Of_Objects_Unique 425.30464004590357 ns/iter 413.7014664431237 ns/iter 1.03
JSON_Parse_1 9686.671985889298 ns/iter 10241.035699254926 ns/iter 0.95
JSON_Parse_Real 13278.518240851683 ns/iter 13523.499330186074 ns/iter 0.98
JSON_Parse_Decimal 16990.408175732628 ns/iter 19690.672590546834 ns/iter 0.86
JSON_Parse_Schema_ISO_Language 5736880.380165403 ns/iter 5611040.185483819 ns/iter 1.02
JSON_Fast_Hash_Helm_Chart_Lock 61.63022968706207 ns/iter 68.9069574781503 ns/iter 0.89
JSON_Equality_Helm_Chart_Lock 182.5482821656731 ns/iter 164.04341021841282 ns/iter 1.11
JSON_Divisible_By_Decimal 229.9658975049883 ns/iter 240.53339179959204 ns/iter 0.96
JSON_String_Equal/10 6.09206318357764 ns/iter 6.046070262280337 ns/iter 1.01
JSON_String_Equal/100 6.797266440776712 ns/iter 6.681433598676238 ns/iter 1.02
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7111828637651588 ns/iter 0.7410528161376696 ns/iter 0.96
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 22.007291590685163 ns/iter 25.207671084052116 ns/iter 0.87
JSON_String_Fast_Hash/10 1.0554646335088536 ns/iter 1.5586464136429263 ns/iter 0.68
JSON_String_Fast_Hash/100 1.0560935232483908 ns/iter 1.5603487268069778 ns/iter 0.68
JSON_String_Key_Hash/10 1.0859904278142658 ns/iter 1.2477389076055014 ns/iter 0.87
JSON_String_Key_Hash/100 14.760533984240833 ns/iter 12.448426907279805 ns/iter 1.19
JSON_Object_Defines_Miss_Same_Length 3.869414373576015 ns/iter 3.426401381280458 ns/iter 1.13
JSON_Object_Defines_Miss_Too_Small 3.517009570467429 ns/iter 3.1137227640470213 ns/iter 1.13
JSON_Object_Defines_Miss_Too_Large 3.5181436185309214 ns/iter 3.7391122379919826 ns/iter 0.94
Regex_Lower_S_Or_Upper_S_Asterisk 0.7040454383088882 ns/iter 0.6231670394457955 ns/iter 1.13
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 0.7037579781527744 ns/iter 0.6230485352549741 ns/iter 1.13
Regex_Period_Asterisk 0.7039409583017958 ns/iter 0.934115067826437 ns/iter 0.75
Regex_Group_Period_Asterisk_Group 0.7041841099542786 ns/iter 0.934764100992373 ns/iter 0.75
Regex_Period_Plus 0.7034154982268737 ns/iter 0.6235181613687408 ns/iter 1.13
Regex_Period 0.7036160034724639 ns/iter 0.6261766686712037 ns/iter 1.12
Regex_Caret_Period_Plus_Dollar 0.7034689135616933 ns/iter 0.9348262222695205 ns/iter 0.75
Regex_Caret_Group_Period_Plus_Group_Dollar 0.7035518636903805 ns/iter 0.9343245383489586 ns/iter 0.75
Regex_Caret_Period_Asterisk_Dollar 0.7037333767544328 ns/iter 0.6232696635453512 ns/iter 1.13
Regex_Caret_Group_Period_Asterisk_Group_Dollar 0.7044084109790708 ns/iter 0.6226886437997174 ns/iter 1.13
Regex_Caret_X_Hyphen 3.9333413212442596 ns/iter 4.054225995536224 ns/iter 0.97
Regex_Period_Md_Dollar 41.67004668548624 ns/iter 27.744254807489373 ns/iter 1.50
Regex_Caret_Slash_Period_Asterisk 4.222341706898746 ns/iter 4.670092629386577 ns/iter 0.90
Regex_Caret_Period_Range_Dollar 1.0553804257746888 ns/iter 0.7795028594537237 ns/iter 1.35
Regex_Nested_Backtrack 45.6495785247098 ns/iter 36.07246655749801 ns/iter 1.27

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: b972df0 Previous: a75b850 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.5822416881068433 ns/iter 2.4698821373262785 ns/iter 1.05
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.4911638180150204 ns/iter 2.462879687839191 ns/iter 1.01
Regex_Period_Asterisk 2.210503488686834 ns/iter 2.4644619179589196 ns/iter 0.90
Regex_Group_Period_Asterisk_Group 2.207337857223584 ns/iter 2.4631481245664513 ns/iter 0.90
Regex_Period_Plus 3.11374975926314 ns/iter 3.8667931111990854 ns/iter 0.81
Regex_Period 3.126244188954374 ns/iter 3.8677244152537558 ns/iter 0.81
Regex_Caret_Period_Plus_Dollar 2.8038179993038064 ns/iter 3.5144274210952973 ns/iter 0.80
Regex_Caret_Group_Period_Plus_Group_Dollar 2.8069060208401813 ns/iter 3.5147233787267487 ns/iter 0.80
Regex_Caret_Period_Asterisk_Dollar 3.735346082761259 ns/iter 2.8140455704231493 ns/iter 1.33
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.7357943838336336 ns/iter 2.8161102425696707 ns/iter 1.33
Regex_Caret_X_Hyphen 6.855120669975155 ns/iter 6.731944761647275 ns/iter 1.02
Regex_Period_Md_Dollar 28.7246062300737 ns/iter 26.290777751885273 ns/iter 1.09
Regex_Caret_Slash_Period_Asterisk 7.481486188100921 ns/iter 7.385232304747451 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 2.8198647796197247 ns/iter 3.867102560052178 ns/iter 0.73
Regex_Nested_Backtrack 45.89992445862785 ns/iter 38.31666913667312 ns/iter 1.20
JSON_Array_Of_Objects_Unique 444.74744870689494 ns/iter 468.4341557539961 ns/iter 0.95
JSON_Parse_1 6636.0315938335625 ns/iter 6800.321019589722 ns/iter 0.98
JSON_Parse_Real 11254.106049350454 ns/iter 11886.100195561801 ns/iter 0.95
JSON_Parse_Decimal 11099.87975958276 ns/iter 11723.270609944117 ns/iter 0.95
JSON_Parse_Schema_ISO_Language 3843752.428571116 ns/iter 4048407.4682079786 ns/iter 0.95
JSON_Fast_Hash_Helm_Chart_Lock 66.33961195535372 ns/iter 79.75270562647057 ns/iter 0.83
JSON_Equality_Helm_Chart_Lock 157.81304007053163 ns/iter 180.67746411706324 ns/iter 0.87
JSON_Divisible_By_Decimal 253.06344806229458 ns/iter 247.320336488715 ns/iter 1.02
JSON_String_Equal/10 6.233949785545646 ns/iter 6.342127717854702 ns/iter 0.98
JSON_String_Equal/100 6.859427382153928 ns/iter 7.033019240639982 ns/iter 0.98
JSON_String_Equal_Small_By_Perfect_Hash/10 0.939283008734188 ns/iter 1.0544731557900258 ns/iter 0.89
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 10.67449197504731 ns/iter 12.375212259083632 ns/iter 0.86
JSON_String_Fast_Hash/10 3.1145500598931086 ns/iter 3.170107003233216 ns/iter 0.98
JSON_String_Fast_Hash/100 3.1272718661167302 ns/iter 3.1679328932987914 ns/iter 0.99
JSON_String_Key_Hash/10 2.182877023786891 ns/iter 2.4611878306787403 ns/iter 0.89
JSON_String_Key_Hash/100 6.538923460917979 ns/iter 7.731749557121 ns/iter 0.85
JSON_Object_Defines_Miss_Same_Length 2.7586858991970065 ns/iter 2.9267740817977432 ns/iter 0.94
JSON_Object_Defines_Miss_Too_Small 2.760079089628372 ns/iter 2.9219232268419013 ns/iter 0.94
JSON_Object_Defines_Miss_Too_Large 3.7391383257928186 ns/iter 4.225125251687464 ns/iter 0.88
Pointer_Object_Traverse 24.396077328992426 ns/iter 25.715496324411514 ns/iter 0.95
Pointer_Object_Try_Traverse 30.237212655345626 ns/iter 28.78306493279745 ns/iter 1.05
Pointer_Push_Back_Pointer_To_Weak_Pointer 150.81789769591433 ns/iter 169.6705116807125 ns/iter 0.89
Pointer_Walker_Schema_ISO_Language 1680238.677804178 ns/iter 3181625.0675675077 ns/iter 0.53
Pointer_Maybe_Tracked_Deeply_Nested/0 1529975.430130941 ns/iter 1444141.8604166736 ns/iter 1.06
Pointer_Maybe_Tracked_Deeply_Nested/1 1822615.3884512468 ns/iter 1780597.8396946434 ns/iter 1.02
Pointer_Position_Tracker_Get_Deeply_Nested 612.8489163562219 ns/iter 726.5368367146208 ns/iter 0.84
URITemplateRouter_Create 32003.053554481856 ns/iter 29858.779556388905 ns/iter 1.07
URITemplateRouter_Match 174.49293027210226 ns/iter 180.67043085355346 ns/iter 0.97
URITemplateRouter_Match_BasePath 200.60296624482456 ns/iter 213.45429907991593 ns/iter 0.94
URITemplateRouterView_Restore 7913.9347441273485 ns/iter 8894.600029309982 ns/iter 0.89
URITemplateRouterView_Match 148.4996558640776 ns/iter 145.6984393727759 ns/iter 1.02
URITemplateRouterView_Match_BasePath 169.4378818276106 ns/iter 163.4728742308199 ns/iter 1.04
URITemplateRouterView_Arguments 432.8679938704399 ns/iter 454.6311363045562 ns/iter 0.95
JSONL_Parse_Large 12199330.396552358 ns/iter 10973875.984374715 ns/iter 1.11
JSONL_Parse_Large_GZIP 13647402.21153992 ns/iter 12758768.400001166 ns/iter 1.07
HTML_Build_Table_100000 69190220.79999878 ns/iter 85783285.4999998 ns/iter 0.81
HTML_Render_Table_100000 5415008.457364736 ns/iter 4833963.388889294 ns/iter 1.12
GZIP_Compress_ISO_Language_Set_3_Locations 32831425.04761556 ns/iter 36521806.52631829 ns/iter 0.90
GZIP_Decompress_ISO_Language_Set_3_Locations 4107722.351190681 ns/iter 4729292.108107542 ns/iter 0.87
GZIP_Compress_ISO_Language_Set_3_Schema 1861540.9760001663 ns/iter 2136884.9969513942 ns/iter 0.87
GZIP_Decompress_ISO_Language_Set_3_Schema 356067.01935809746 ns/iter 294408.3286482287 ns/iter 1.21

This comment was automatically generated by workflow using github-action-benchmark.

jviotti added 2 commits June 10, 2026 13:21
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti marked this pull request as ready for review June 10, 2026 17:31
@jviotti jviotti changed the title Correctness review Repository-wide correctness review Jun 10, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 issues found across 92 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/core/unicode/unicode.cc Outdated
Comment thread src/core/html/include/sourcemeta/core/html_writer.h
Comment thread src/core/regex/regex.cc
Comment thread src/core/uri/canonicalize.cc
Comment thread src/core/jsonpointer/include/sourcemeta/core/jsonpointer_token.h
Comment thread src/core/unicode/unicode.cc
@augmentcode

augmentcode Bot commented Jun 10, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR is a broad correctness hardening pass across core utilities (DNS/IDNA, gzip/deflate, JSON/JSON Pointer, URI, I/O, numeric, and parsing helpers).

Changes:

  • Improves gzip/deflate robustness (buffer refill API, header FHCRC handling without unbounded buffering, Huffman completeness checks, dynamic-header HLIT bound, and configurable compression level).
  • Tightens IDNA/A-label validation (canonical Punycode round-trip, 63-octet label caps) and strengthens Punycode scalar-value validation.
  • Makes JSON operations safer (deterministic object ordering for sorting, safer self-referential copy/move assignment, self-merge handling, and input-size guarding for the tape format).
  • Updates HTTP parameter parsing and q-value handling to treat malformed weights as fail-safe refusal (0) and to respect quoted semicolons.
  • Hardens URI normalization and setters (only decode unreserved during normalization; reject raw paths containing query/fragment; path accessor now returns views).
  • Adds safety toggles/limits in other components (Markdown safe mode, PCRE2 match/depth limits, YAML alias-expansion bounding, atomic file staging-name randomization, zero-length file mapping handling, POSIX spawn argument ownership, and alternate crash-handler stack).

Technical Notes: Several changes intentionally align behavior with RFC requirements and common tool behavior (e.g., gzip(1) trailing data tolerance, RFC 1951/1952/3986/5890/9110 constraints), and new tests cover many newly-handled edge cases.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread src/core/html/include/sourcemeta/core/html_writer.h
Comment thread src/core/regex/regex.cc
jviotti added 2 commits June 10, 2026 13:38
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: b972df0 Previous: a75b850 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.1261148089651067 ns/iter 2.53996326375768 ns/iter 0.84
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.9680980190638981 ns/iter 2.133428504039956 ns/iter 0.92
Regex_Period_Asterisk 1.9449465140092062 ns/iter 2.216129836482011 ns/iter 0.88
Regex_Group_Period_Asterisk_Group 2.0297528971573704 ns/iter 2.344142234454588 ns/iter 0.87
Regex_Period_Plus 2.4251097469509038 ns/iter 2.608238684450945 ns/iter 0.93
Regex_Period 2.59863396999519 ns/iter 2.439879106289414 ns/iter 1.07
Regex_Caret_Period_Plus_Dollar 2.616863310482433 ns/iter 2.3569228772097155 ns/iter 1.11
Regex_Caret_Group_Period_Plus_Group_Dollar 2.3078770068153083 ns/iter 2.387947191298286 ns/iter 0.97
Regex_Caret_Period_Asterisk_Dollar 1.9800309536937768 ns/iter 2.0894857884653604 ns/iter 0.95
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.969744888879587 ns/iter 2.1905737339253575 ns/iter 0.90
Regex_Caret_X_Hyphen 7.3191888675727235 ns/iter 7.559950512365727 ns/iter 0.97
Regex_Period_Md_Dollar 26.173984820274416 ns/iter 22.736525495007736 ns/iter 1.15
Regex_Caret_Slash_Period_Asterisk 5.542071080385335 ns/iter 6.181430600549019 ns/iter 0.90
Regex_Caret_Period_Range_Dollar 2.5206938302609636 ns/iter 2.4817594829372833 ns/iter 1.02
Regex_Nested_Backtrack 41.158851581456254 ns/iter 33.30295326405854 ns/iter 1.24
JSON_Array_Of_Objects_Unique 613.7933358507184 ns/iter 521.0726144772846 ns/iter 1.18
JSON_Parse_1 6477.340839999214 ns/iter 6335.024491860999 ns/iter 1.02
JSON_Parse_Real 10738.203299073975 ns/iter 8619.428818693143 ns/iter 1.25
JSON_Parse_Decimal 13292.800798970586 ns/iter 11136.793451699428 ns/iter 1.19
JSON_Parse_Schema_ISO_Language 6261174.089108817 ns/iter 3954663.4615384093 ns/iter 1.58
JSON_Fast_Hash_Helm_Chart_Lock 82.34889214937634 ns/iter 72.683689743588 ns/iter 1.13
JSON_Equality_Helm_Chart_Lock 166.24054808168407 ns/iter 161.05159978428725 ns/iter 1.03
JSON_Divisible_By_Decimal 225.55287787597655 ns/iter 195.5282401552067 ns/iter 1.15
JSON_String_Equal/10 7.936399133645162 ns/iter 7.472163398707338 ns/iter 1.06
JSON_String_Equal/100 7.110738619403847 ns/iter 7.713066708824235 ns/iter 0.92
JSON_String_Equal_Small_By_Perfect_Hash/10 0.8688747278544108 ns/iter 0.880212471246488 ns/iter 0.99
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.813039761072901 ns/iter 3.539061129692514 ns/iter 1.08
JSON_String_Fast_Hash/10 3.2351776156025163 ns/iter 2.5512917319455832 ns/iter 1.27
JSON_String_Fast_Hash/100 2.671531924808956 ns/iter 2.192406943268044 ns/iter 1.22
JSON_String_Key_Hash/10 1.8260095075492508 ns/iter 1.5583802522618224 ns/iter 1.17
JSON_String_Key_Hash/100 2.975140570746588 ns/iter 2.7987510493105963 ns/iter 1.06
JSON_Object_Defines_Miss_Same_Length 3.0526415414135912 ns/iter 2.5384938839140228 ns/iter 1.20
JSON_Object_Defines_Miss_Too_Small 2.990139125018208 ns/iter 2.7633409447088484 ns/iter 1.08
JSON_Object_Defines_Miss_Too_Large 2.9968678110382903 ns/iter 2.981322993606194 ns/iter 1.01
Pointer_Object_Traverse 18.485604634962513 ns/iter 20.59297943208545 ns/iter 0.90
Pointer_Object_Try_Traverse 30.641769874310487 ns/iter 34.78833441120037 ns/iter 0.88
Pointer_Push_Back_Pointer_To_Weak_Pointer 197.0097794052456 ns/iter 195.6950203978664 ns/iter 1.01
Pointer_Walker_Schema_ISO_Language 3464639.9253727878 ns/iter 5337479.99999946 ns/iter 0.65
Pointer_Maybe_Tracked_Deeply_Nested/0 1524806.947895877 ns/iter 1178588.9954199004 ns/iter 1.29
Pointer_Maybe_Tracked_Deeply_Nested/1 2156832.524271837 ns/iter 1740137.0774337011 ns/iter 1.24
Pointer_Position_Tracker_Get_Deeply_Nested 477.40672975827874 ns/iter 528.5057496555496 ns/iter 0.90
URITemplateRouter_Create 33419.774263471656 ns/iter 29489.922786965584 ns/iter 1.13
URITemplateRouter_Match 221.97264132537373 ns/iter 211.06970985070146 ns/iter 1.05
URITemplateRouter_Match_BasePath 257.04432873393677 ns/iter 239.06052268617853 ns/iter 1.08
URITemplateRouterView_Restore 14343.892130639762 ns/iter 12694.946840447568 ns/iter 1.13
URITemplateRouterView_Match 175.7195489724706 ns/iter 188.04648081047912 ns/iter 0.93
URITemplateRouterView_Match_BasePath 198.29760578809112 ns/iter 189.50993512916332 ns/iter 1.05
URITemplateRouterView_Arguments 507.49401073810134 ns/iter 546.8060823677387 ns/iter 0.93
JSONL_Parse_Large 19764659.514287684 ns/iter 17742111.486485727 ns/iter 1.11
JSONL_Parse_Large_GZIP 24329459.851851765 ns/iter 18534016.025642022 ns/iter 1.31
HTML_Build_Table_100000 99795680.50001337 ns/iter 78049398.22221968 ns/iter 1.28
HTML_Render_Table_100000 5769788.590164054 ns/iter 4688368.144736675 ns/iter 1.23
GZIP_Compress_ISO_Language_Set_3_Locations 39150978.05263127 ns/iter 33165791.666668892 ns/iter 1.18
GZIP_Decompress_ISO_Language_Set_3_Locations 7281805.558558485 ns/iter 6118112.678261598 ns/iter 1.19
GZIP_Compress_ISO_Language_Set_3_Schema 2019427.8364610288 ns/iter 2020712.419618504 ns/iter 1.00
GZIP_Decompress_ISO_Language_Set_3_Schema 318859.3161689332 ns/iter 360125.5292516742 ns/iter 0.89

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: b972df0 Previous: a75b850 Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 5.078656999999112 ns/iter 2.55297035714323 ns/iter 1.99
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 5.045820000000276 ns/iter 2.5683910702818173 ns/iter 1.96
Regex_Period_Asterisk 5.036142999999811 ns/iter 2.509186785714844 ns/iter 2.01
Regex_Group_Period_Asterisk_Group 5.15295100000003 ns/iter 2.521318214286339 ns/iter 2.04
Regex_Period_Plus 4.739965858793579 ns/iter 2.5894547967950503 ns/iter 1.83
Regex_Period 4.864588999998887 ns/iter 2.561065935212843 ns/iter 1.90
Regex_Caret_Period_Plus_Dollar 4.7464546980949045 ns/iter 2.5842367834072135 ns/iter 1.84
Regex_Caret_Group_Period_Plus_Group_Dollar 4.7309570546271305 ns/iter 2.520331428571256 ns/iter 1.88
Regex_Caret_Period_Asterisk_Dollar 5.051716000000397 ns/iter 2.6032160691037447 ns/iter 1.94
Regex_Caret_Group_Period_Asterisk_Group_Dollar 5.10658999999805 ns/iter 2.501304285714566 ns/iter 2.04
Regex_Caret_X_Hyphen 8.33406960564975 ns/iter 4.095091203529435 ns/iter 2.04
Regex_Period_Md_Dollar 45.88734691172 ns/iter 20.39560451422717 ns/iter 2.25
Regex_Caret_Slash_Period_Asterisk 7.895367187499756 ns/iter 4.298116136474223 ns/iter 1.84
Regex_Caret_Period_Range_Dollar 6.073689285713613 ns/iter 2.8482295969426685 ns/iter 2.13
Regex_Nested_Backtrack 55.97624107143215 ns/iter 25.75581602069062 ns/iter 2.17
JSON_Array_Of_Objects_Unique 504.3304000000717 ns/iter 245.6844285714104 ns/iter 2.05
JSON_Parse_1 11412.689285715975 ns/iter 8178.885044642925 ns/iter 1.40
JSON_Parse_Real 18937.087831139906 ns/iter 11191.443750000473 ns/iter 1.69
JSON_Parse_Decimal 18292.707540453903 ns/iter 10392.546874999909 ns/iter 1.76
JSON_Parse_Schema_ISO_Language 8575772.222222138 ns/iter 5615013.999999974 ns/iter 1.53
JSON_Fast_Hash_Helm_Chart_Lock 67.97964285714744 ns/iter 33.603530212559065 ns/iter 2.02
JSON_Equality_Helm_Chart_Lock 300.93345971716974 ns/iter 135.73512117254057 ns/iter 2.22
JSON_Divisible_By_Decimal 302.96404207987473 ns/iter 167.27760048734552 ns/iter 1.81
JSON_String_Equal/10 15.388993303570178 ns/iter 6.977093749999393 ns/iter 2.21
JSON_String_Equal/100 16.442263392854834 ns/iter 7.282924107143073 ns/iter 2.26
JSON_String_Equal_Small_By_Perfect_Hash/10 2.517602142857608 ns/iter 1.1272485937499965 ns/iter 2.23
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.185593749996679 ns/iter 7.538187499999285 ns/iter 1.88
JSON_String_Fast_Hash/10 4.721070268910741 ns/iter 2.281251875000123 ns/iter 2.07
JSON_String_Fast_Hash/100 4.834906697508407 ns/iter 2.302903125000455 ns/iter 2.10
JSON_String_Key_Hash/10 5.732648999999128 ns/iter 2.5316145736325404 ns/iter 2.26
JSON_String_Key_Hash/100 11.927132142854395 ns/iter 6.130760714285088 ns/iter 1.95
JSON_Object_Defines_Miss_Same_Length 4.098339962676764 ns/iter 2.026223081713764 ns/iter 2.02
JSON_Object_Defines_Miss_Too_Small 4.749629710880961 ns/iter 2.169097877043061 ns/iter 2.19
JSON_Object_Defines_Miss_Too_Large 4.199974752589629 ns/iter 2.2837628099513108 ns/iter 1.84
Pointer_Object_Traverse 70.02987500001723 ns/iter 31.3950312499957 ns/iter 2.23
Pointer_Object_Try_Traverse 69.12061607142813 ns/iter 31.615969243995693 ns/iter 2.19
Pointer_Push_Back_Pointer_To_Weak_Pointer 186.66501845241882 ns/iter 177.5447261748698 ns/iter 1.05
Pointer_Walker_Schema_ISO_Language 7758995.535713861 ns/iter 9073864.000001777 ns/iter 0.86
Pointer_Maybe_Tracked_Deeply_Nested/0 2577126.694915424 ns/iter 1544442.6273458991 ns/iter 1.67
Pointer_Maybe_Tracked_Deeply_Nested/1 4159413.9534886167 ns/iter 2222228.7625421 ns/iter 1.87
Pointer_Position_Tracker_Get_Deeply_Nested 517.8892560575379 ns/iter 362.9849888392909 ns/iter 1.43
URITemplateRouter_Create 41042.040508388716 ns/iter 24268.02142857046 ns/iter 1.69
URITemplateRouter_Match 191.6274278239139 ns/iter 99.22881249998738 ns/iter 1.93
URITemplateRouter_Match_BasePath 216.95056250003117 ns/iter 110.75625000000146 ns/iter 1.96
URITemplateRouterView_Restore 34695.644274208345 ns/iter 13763.311101289211 ns/iter 2.52
URITemplateRouterView_Match 157.81861607143202 ns/iter 74.23965401786502 ns/iter 2.13
URITemplateRouterView_Match_BasePath 175.7688644488194 ns/iter 86.25575507783904 ns/iter 2.04
URITemplateRouterView_Arguments 523.6379000000397 ns/iter 323.96770686986696 ns/iter 1.62
JSONL_Parse_Large 34817640.00000567 ns/iter 22118099.999996353 ns/iter 1.57
JSONL_Parse_Large_GZIP 35303036.84210354 ns/iter 22614203.125002064 ns/iter 1.56
HTML_Build_Table_100000 90590214.28574203 ns/iter 51455654.545448355 ns/iter 1.76
HTML_Render_Table_100000 8057368.888888858 ns/iter 5059527.999999318 ns/iter 1.59
GZIP_Compress_ISO_Language_Set_3_Locations 36306205.26315684 ns/iter 24173732.142855894 ns/iter 1.50
GZIP_Decompress_ISO_Language_Set_3_Locations 10086368.00000204 ns/iter 5421711.999999843 ns/iter 1.86
GZIP_Compress_ISO_Language_Set_3_Schema 2086821.1594204144 ns/iter 1416504.6184737012 ns/iter 1.47
GZIP_Decompress_ISO_Language_Set_3_Schema 624512.7678570027 ns/iter 418051.84151793335 ns/iter 1.49

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 9ccb267 into main Jun 10, 2026
13 checks passed
@jviotti jviotti deleted the core-review branch June 10, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant