fix: proposed fix for competing UI on mobile#17
Open
xmreur wants to merge 1 commit into
Open
Conversation
|
|
Owner
|
Thanks! I'll check this once I find time 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves mobile gameplay by replacing the cramped bottom minimap strip with a full-screen Street View / map toggle.
On viewports under 768px, Street View now uses the full screen by default. A floating Guess button (bottom-right) opens a full-screen map overlay for pin placement; Back returns to Street View. The existing Place Pin / Guess / Waiting finalize flow is unchanged. Desktop keeps the hover-to-expand bottom-right minimap.
What changed:
MinimapPanel — Mobile uses a two-state mapViewOpen toggle instead of tap-to-expand partial minimap, backdrop collapse, and the 80px right gutter. Map overlay sits at z-30 (below HUD at z-40). New optional roundKey prop resets to Street View when the round changes.
InGameScene — Passes roundKey={streetViewSrc} so each new round starts in Street View.
MinimapPanel.test.tsx — Tests for mobile toggle, round reset, and unchanged desktop behavior.