feat(mcp): build flagset from mcp input schema to parse args #1215
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| package mcp | ||
|
|
||
| import ( | ||
| "flag" | ||
| "fmt" | ||
| "reflect" | ||
| "strings" | ||
|
|
||
| "github.com/sourcegraph/sourcegraph/lib/errors" | ||
| ) | ||
|
|
||
| var _ flag.Value = (*strSliceFlag)(nil) | ||
|
|
||
| type strSliceFlag struct { | ||
| vals []string | ||
| } | ||
|
|
||
| func (s *strSliceFlag) Set(v string) error { | ||
| s.vals = append(s.vals, v) | ||
| return nil | ||
| } | ||
|
|
||
| func (s *strSliceFlag) String() string { | ||
| return strings.Join(s.vals, ",") | ||
| } | ||
|
|
||
| func DerefFlagValues(vars map[string]any) { | ||
| for k, v := range vars { | ||
| rfl := reflect.ValueOf(v) | ||
| if rfl.Kind() == reflect.Pointer { | ||
| vv := rfl.Elem().Interface() | ||
| if slice, ok := vv.(strSliceFlag); ok { | ||
| vv = slice.vals | ||
| } | ||
| if isNil(vv) { | ||
| delete(vars, k) | ||
| } else { | ||
| vars[k] = vv | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func isNil(v any) bool { | ||
| if v == nil { | ||
| return true | ||
| } | ||
| rv := reflect.ValueOf(v) | ||
| switch rv.Kind() { | ||
| case reflect.Slice, reflect.Map, reflect.Pointer, reflect.Interface: | ||
| return rv.IsNil() | ||
| default: | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| func BuildArgFlagSet(tool *ToolDef) (*flag.FlagSet, map[string]any, error) { | ||
| if tool == nil { | ||
| return nil, nil, errors.New("cannot build flagset on nil Tool Definition") | ||
| } | ||
| fs := flag.NewFlagSet(tool.Name, flag.ContinueOnError) | ||
| flagVars := map[string]any{} | ||
|
|
||
| for name, pVal := range tool.InputSchema.Properties { | ||
| switch pv := pVal.(type) { | ||
| case *SchemaPrimitive: | ||
| switch pv.Type { | ||
| case "integer": | ||
| dst := fs.Int(name, 0, pv.Description) | ||
| flagVars[name] = dst | ||
|
|
||
| case "boolean": | ||
| dst := fs.Bool(name, false, pv.Description) | ||
| flagVars[name] = dst | ||
| case "string": | ||
| dst := fs.String(name, "", pv.Description) | ||
| flagVars[name] = dst | ||
| default: | ||
| return nil, nil, fmt.Errorf("unknown schema primitive kind %q", pv.Type) | ||
|
|
||
| } | ||
| case *SchemaArray: | ||
| strSlice := new(strSliceFlag) | ||
| fs.Var(strSlice, name, pv.Description) | ||
| flagVars[name] = strSlice | ||
| case *SchemaObject: | ||
| // TODO(burmudar): we can support SchemaObject as part of stdin echo '{ stuff }' | sg mcp commit-search | ||
burmudar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // not supported yet | ||
| // Also support sg mcp commit-search --json '{ stuff }' | ||
| } | ||
| } | ||
|
|
||
| return fs, flagVars, nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have nay uses of that in our tools?