Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@vovakulikov
Copy link
Contributor

The main intention to change here is to save vertical space, we already have a few panels and sticky headers in the search result block, and having an additional row in the sticky header above make this panel crowded especially on mid-size screens

Before After
Screenshot 2024-05-01 at 14 16 47 Screenshot 2024-05-01 at 14 15 52

Test plan

  • Check progress result UI on the search result page

@vovakulikov vovakulikov requested review from a team and taiyab May 1, 2024 12:20
@vovakulikov vovakulikov self-assigned this May 1, 2024
@cla-bot cla-bot bot added the cla-signed label May 1, 2024
@camdencheek
Copy link
Member

Looks like this will conflict with https://github.com/sourcegraph/sourcegraph/pull/62317. Thoughts on how we should handle that?

@vovakulikov
Copy link
Contributor Author

So after the pairing session, we agreed that this PR won't go to the May release, instead, we're going to merge https://github.com/sourcegraph/sourcegraph/pull/62317 and in this PR we split the result button into two buttons, info one with result count and reasons badge and action button which populates the query with additional filter to resolve the problem that info button shows

@vovakulikov vovakulikov marked this pull request as draft May 1, 2024 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants