Remove duplicate comma in generated server code#1
Open
shawnblakesley wants to merge 1 commit into
Open
Conversation
This seems to be generating a duplicate comma for me. Tried it out locally with a service that has more than one rpc, and this change fixed it. Haven't done thorough testing yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried adding more rpcs to my service, and they failed to generate the twirp bindings.
Did some digging into the following error, and the output had duplicate commas:
Since there is already a comma in the creation of
match_arms, combining the vec elements with commas is what I believe to be the cause of the error.Got this working locally by depending on my fork.
Example proto file that exposed the error: