Conversation
PeterJCLaw
left a comment
PeterJCLaw
left a comment
There was a problem hiding this comment.
Seems good; I'll have a more complete look when I've time to test it out.
We should check that robotd (and robot-api) have stopped using these features before removing them. I know we want to do that, so hopefully this is just a case of remove the dead code there too (first).
CircleCI is highlighting that there's an import of numpy in coordinates.py which is unused. Note that coordinates.py imports numpy both as a module and some functions from it; only one of these can be removed.
(It looks like the CI previously correctly highlighted the erroneous removal of a similar import from tokens.py)
|
|
||
| # Polar co-ordinates in the 3D world, relative to the camera | ||
| self.polar = cartesian_to_legacy_polar(self.cartesian) | ||
| self.legacy_polar = cartesian_to_legacy_polar(self.cartesian) |
There was a problem hiding this comment.
We should ensure that the robotd changes to remove legacy_polar happen before this change is merged.
…ision into remove-deprecated-coords
2 participants
Do not merge until this system has been removed from both
docsandrobot-api