Skip to content

Jminnetian/fix connector scrolling#1418

Merged
jsourcebot merged 2 commits into
mainfrom
jminnetian/fix-connector-scrolling
Jul 2, 2026
Merged

Jminnetian/fix connector scrolling#1418
jsourcebot merged 2 commits into
mainfrom
jminnetian/fix-connector-scrolling

Conversation

@jsourcebot

@jsourcebot jsourcebot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Fix connector add dialog scrolling if it does not fit in the display.

Summary by CodeRabbit

  • Bug Fixes
    • Connector setup dialogs now scroll when content exceeds the visible area.
    • Improved the layout and scrolling behavior across several connector-related dialogs for a more consistent experience.
    • Enhanced the OAuth scopes list so it behaves better within long dialog content.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3b07f64d-54f6-4274-87d2-8d728aeb1e2e

📥 Commits

Reviewing files that changed from the base of the PR and between fd6720f and 2372b09.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • packages/web/src/app/(app)/settings/workspaceAskAgent/workspaceAskAgentPage.tsx

Walkthrough

Adds shared CSS class constants for scrollable dialog content/body and applies them across four dialogs (Add Connector, OAuth Scopes, Edit OAuth Scopes, OAuth Client Credentials Required) in the workspace Ask Agent settings page, along with a corresponding CHANGELOG entry.

Changes

Dialog scroll fix

Layer / File(s) Summary
Shared scroll class constants
packages/web/src/app/(app)/settings/workspaceAskAgent/workspaceAskAgentPage.tsx
Adds shared constants for scrollable dialog content/body classes and updates the OAuth scope list container to include overscroll-contain.
Apply scroll classes to dialogs
packages/web/src/app/(app)/settings/workspaceAskAgent/workspaceAskAgentPage.tsx
Applies the shared scrollable classes and shrink-0 header/footer styling to the Add Connector, OAuth Scopes, Edit OAuth Scopes, and OAuth Client Credentials Required dialogs, removing prior body padding.
Changelog entry
CHANGELOG.md
Adds an EE Fixed entry noting connector setup dialogs now scroll when content overflows.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Related issues: None referenced.

Suggested labels: ee, ui, bug-fix

Suggested reviewers: None specified.

Poem

A rabbit hopped through dialogs tall,
Content overflowed, threatened to sprawl,
Now scrollbars glide with gentle grace,
Shrink-0 headers hold their place,
Scroll on, little modal, scroll on through it all. 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing connector dialog scrolling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jminnetian/fix-connector-scrolling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jsourcebot jsourcebot merged commit 9baeac1 into main Jul 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant