chore: make backend worker API URL configurable via WORKER_API_URL#1409
Merged
Conversation
The backend worker API host/port was hardcoded to localhost:3060 in both the worker (api.ts) and the web app that calls it (workerApi/actions.ts). Add a WORKER_API_URL env var (default http://localhost:3060): the web app dials it, and the worker derives its listen port from it, so the two can't drift. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughIntroduces a ChangesWORKER_API_URL configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)sequenceDiagram
participant EnvServer as env.server.ts
participant BackendApi as api.ts
participant WebActions as actions.ts
EnvServer->>EnvServer: define WORKER_API_URL with default http://localhost:3060
BackendApi->>EnvServer: read env.WORKER_API_URL
BackendApi->>BackendApi: parse URL, derive PORT (explicit, or 443/80 by protocol)
WebActions->>EnvServer: read env.WORKER_API_URL
WebActions->>WebActions: use WORKER_API_URL as fetch base URL
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend worker API was hardcoded to
localhost:3060in both the worker (api.ts) and the web app that calls it (workerApi/actions.ts). This adds a singleWORKER_API_URLenv var (defaulthttp://localhost:3060): the web app dials it, and the worker derives its listen port from it, so the URL and port can't drift.🤖 Generated with Claude Code
Summary by CodeRabbit