feature: Add full screen support for ObjectPreview iframes#211
Closed
cmsetzer wants to merge 1 commit intosource-cooperative:mainfrom
Closed
feature: Add full screen support for ObjectPreview iframes#211cmsetzer wants to merge 1 commit intosource-cooperative:mainfrom
cmsetzer wants to merge 1 commit intosource-cooperative:mainfrom
Conversation
|
@cmsetzer is attempting to deploy a commit to the Radiant Earth Team on Vercel. A member of the Team first needs to authorize it. |
cmsetzer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I'm changing
This change enables the ObjectPreview
iframeelement to launch full screen mode for viewers that request it, such as the image and 3D model viewers from #210.How I did it
I've added the permissions policy
allow="fullscreen"to theiframein ObjectPreview. This should let any current or future viewer launch full screen mode.How you can test it
On a preview branch where this feature is active, navigate to the following pages and click the "Toggle full screen" button within the preview
iframe: