Fixed development access token generation bug#1335
Open
geraldnyeo wants to merge 11 commits intosource-academy:masterfrom
Open
Fixed development access token generation bug#1335geraldnyeo wants to merge 11 commits intosource-academy:masterfrom
geraldnyeo wants to merge 11 commits intosource-academy:masterfrom
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
62
to
69
| if Cadet.Env.env() in @env_allow_mock do | ||
| user = | ||
| User | ||
| |> where(role: ^role) | ||
| |> join(:inner, [u], cr in "course_registrations", on: u.id == cr.user_id) | ||
| |> where([u, cr], cr.role == ^role) | ||
| |> first | ||
| |> Repo.one() | ||
|
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This reverts commit 7e7bea7.
lib/mix/tasks/token.ex
Outdated
Comment on lines
74
to
78
| %User{} | ||
| |> User.changeset(%{name: "Test#{role_capitalized}", role: role}) | ||
| |> User.changeset(%{name: "Test#{role_capitalized}", username: "test_#{role}", provider: "test"}) | ||
| |> Repo.insert!() | ||
| end | ||
| end |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lib/mix/tasks/token.ex
Outdated
Comment on lines
76
to
78
| course = case Repo.one(Course) do | ||
| course -> course | ||
| nil -> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lib/mix/tasks/token.ex
Outdated
| %User{} | ||
| |> User.changeset(%{name: "Test#{role_capitalized}", role: role}) | ||
| course = | ||
| case Repo.one(Course) do |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1334
Updated query in the test_user function in lib/mix/tasks/token.ex to include a join clause between the 'users' and 'courses' table.