Open
Conversation
- Add progress_modal macro and helpers (spinner, status_badge, message_log, labeled_value, modal_footer_start/end) to modal.html - Refactor selection_progress_modal.html to use the new design system macros - Add progressModalDemo Alpine component for interactive showcase demo - Create modal_component.html showcase section with state demos - Add modal section to showcase.html components tab Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add routes for listing/deleting old tabs (start-list, start-delete, progress, cancel) - Add _get_manage_tabs_context helper for view_assembly_selection - Add manage_tabs_progress_modal.html template - Add implementation plan documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Address code quality review feedback. Also document the rule in AGENTS.md. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
gazdagergo
force-pushed
the
manage-gsheet-tabs
branch
from
c69ff31 to
a006dd1
Compare
gazdagergo
changed the title
foobacca
reviewed
Mar 13, 2026
| {# JavaScript for close handlers - CSP compliant with nonce #} | ||
| <script nonce="{{ csp_nonce }}"> | ||
| (function() { | ||
| var closeUrl = '{{ close_url }}'; |
Contributor
There was a problem hiding this comment.
I thought we added this JavaScript function to one of the static/js/ files - so it is used by all the modals and doesn't need to be added inline here.
Actually just checked, and we didn't. But we do have almost the same JS in selection_progress_modal.html - and presumably also need it for the replacement modal as well. So it probably ought to be a shared piece of JS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Manage Generated Tabs feature to the backoffice
Selection tab, allowing users to list and delete old selection output
tabs from their Google Spreadsheet.
Key Features
Manage Generated Tabs
Design System Improvements
progress_modalmacro with helpers (spinner,status_badge,modal_footer_start/end, etc.)selection_progress_modal.htmlto use new design systemmacros
Bug Fixes & Improvements
@require_assembly_managementdecorator to selection POSTroutes
New Routes
/assembly/<id>/manage-tabs/start-list/assembly/<id>/manage-tabs/start-delete/assembly/<id>/manage-tabs/<run_id>/progress/assembly/<id>/manage-tabs/<run_id>/cancelFiles Changed
backoffice.py: New routes and_get_manage_tabs_contexthelpermodal.html: Newprogress_modalmacro and helpersmanage_tabs_progress_modal.html: New modal templateassembly_selection.html: Enable "List Old Tabs" button with modalinclude
AGENTS.md: Add code style rule for empty except clausesTest Plan