Open
Conversation
Add create/update/delete operations for target categories and values in the service layer, with proper permission checks and validation. Reset max_flex to unset when editing values via the form, since the sortition library recalculates safe defaults at selection time. Also add WTForms for category and value editing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add routes for creating, editing, and deleting target categories and values with HTMX partial page updates. Includes progressive enhancement (forms work without JS), Alpine.js toggle state for edit mode, OOB swaps for adding categories, and 422 status handling for validation errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add unit tests for in-place value mutation, integration tests for all service layer CRUD functions (including max_flex reset), route-level login requirement tests, and e2e tests for add/edit/delete categories and values plus viewer permission checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When categories had a mix of explicit flex values (from CSV import) and unset flex values (from UI-created targets), the adapter wrote empty strings for unset max_flex, causing the sortition library to error with "There is no max_flex value set". Now flex columns are only included when all values have explicit flex; otherwise the library calculates safe defaults via set_default_max_flex(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
* main: Replace inline onclick handlers with data attributes for CSP compliance Improve wording about asking for invite code on front page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a web UI (in the old gov uk style) for create/edit/delete of targets.