Make it build on Windows#3
Open
Meralis40 wants to merge 2 commits into
Open
Conversation
|
@Meralis40 you know how to fix libuv windows linking?: https://gist.github.com/ircnelson/b6bc4c1eefa0291fc7998e370c6402ad Build works fine, but when I execute, it fails.. Installed: cargo new libuv-sample --bin Cargo.toml[dependencies]
libuv-sys = { git = "https://github.com/Meralis40/libuv-rs.git" }main.rsextern crate libuv_sys;
fn main() {
println!("Hello, world!");
} |
Author
|
I've done some modifications to build.rs. I've tested it with vs2015, stable & nightly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request permit to build libuv-sys on Windows with MSVC toolchains.