Skip to content

[Fix] #868 - QA 반영 #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juri123123 wants to merge 2 commits into
base: develop
Choose a base branch
from
+5 −1
Open

[Fix] #868 - QA 반영 #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7c1bcd
[Fix] #868 - 솝트로그 뷰 라우팅 수정
juri123123 May 10, 2026
486414e
[Fix] #868 - 콕찌르기 네트워크 유실 시에 endRefresh 하도록 변경
juri123123 May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion SOPT-iOS/Projects/Domain/Sources/UseCase/PokeMainUseCase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ extension DefaultPokeMainUseCase: PokeMainUseCase {

public func getFriendRandomUser(randomType: PokeRandomUserType, size: Int) {
repository.getFriendRandomUser(randomType: randomType.rawValue, size: size)
.sink { event in
.sink { [weak self] event in
print("GetFriendRandomUser State: \(event)")
if case .failure = event {
self?.friendRandomUsers.send(PokeFriendRandomUserModel(randomInfoList: []))
Copy link
Copy Markdown
Member

@yungu0010 yungu0010 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빈 배열을 보내면 조용한 실패로 리프레시 후 추천 친구 목록이 사라지게 되어 어색한 플로우가 될 것 같습니다.
빈 배열 대신 Error를 ViewModel에 보내 ViewModel이 네트워크 에러 모달을 띄워주도록 하는건 어떠신가요?

Copy link
Copy Markdown
Contributor Author

@juri123123 juri123123 May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 경우가 Publisher3로 use case 3개의 결과를 받아서 처리하는 부분인데,
나머지 usecase들이 빈 배열을 보내고 있어서 비슷하게 처리했습니다!

저도 어색하게 느껴지긴 했어서 나머지 usecase들이 실패했을 때에도 모달 띄우도록 수정해볼게용 !

}
} receiveValue: { [weak self] randomUsers in
self?.friendRandomUsers.send(randomUsers)
}.store(in: cancelBag)
Expand Down
1 change: 1 addition & 0 deletions ...OS/Projects/Features/SoptlogFeature/Sources/SoptlogScene/ViewModel/SoptlogViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ extension SoptlogViewModel {
}.store(in: cancelBag)

input.cellTap
.filter { $0.section == .pokeLog }
.withUnretained(self)
.sink { owner, tapInfo in
switch tapInfo.row {
Expand Down