Open
Conversation
6cf9bdb to
064d9a1
Compare
04e7590 to
32ce898
Compare
739519a to
b118a73
Compare
b118a73 to
6ab80ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently the definition and implementation of
PrioGraphSchedulerand related components is coupled withbanking-stageonsolana-corecrate, with most of useful api availabilty apub(crate), so it's hard to reuse.Summary of Changes
PrioGraphScheduleras indepent component to use.SchedulerControllerhandles a lot of forwarding and decision making logic, which is not related to scheduer itself, so just left insolana_core.ImmutableDeserializedPacket. To avoid circular dependencies, just raise up a Trait typeDeserializableTxPacketand letImmutableDeserializedPacketimpls this trait. It also helps modularity of solana crate.IdGeneratorto replaceTransactionIdGeneratorandBatchIdGenerator, which is quite same.TARGET_NUM_TRANSACTIONS_PER_BATCHandReadWriteAccountSet.