Skip to content

Fix C++11 build using boost #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lo-simon merged 1 commit into from
Nov 14, 2025
Merged

Fix C++11 build using boost #473

lo-simon merged 1 commit into from
Nov 14, 2025

Conversation

@lo-simon
Copy link
Collaborator

@lo-simon lo-simon commented Nov 13, 2025

  • Wrap the catch (const boost::lock_error& e) with a #ifdef BST_THREAD_BOOST to indicate boost is used instead of std.
  • Use std instead of boost if we are permitted to use C++17 in the future. It is because std::shared_mutex will only be available at C++17.

@lo-simon
Wrap the catch (const boost::lock_error& e) with a #ifdef BST_THREAD_…
d1d851a 
…BOOST to indicate boost is used instead of std
jonathan-r-thorpe
jonathan-r-thorpe approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@jonathan-r-thorpe jonathan-r-thorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lo-simon lo-simon merged commit d9d2b83 into sony:master Nov 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-r-thorpe jonathan-r-thorpe jonathan-r-thorpe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lo-simon @jonathan-r-thorpe