Skip to content

feat: run GPU benchmarks with less parallelism #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikonov1101 wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −7
Open

feat: run GPU benchmarks with less parallelism #1867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 30 additions & 7 deletions insonmnia/worker/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1861,15 +1861,38 @@ func (m *Worker) runBenchmark(bench *sonm.Benchmark) error {
case sonm.DeviceType_DEV_NETWORK_OUT:
return m.setBenchmark(bench, m.hardware.Network, m.hardware.Network.BenchmarksOut)
case sonm.DeviceType_DEV_GPU:
//TODO: use context to prevent useless benchmarking in case of error
group := errgroup.Group{}
for _, dev := range m.hardware.GPU {
g := dev
group.Go(func() error {
return m.setBenchmark(bench, g.Device, g.Benchmarks)
devChan := make(chan struct {
bench *sonm.Benchmark
dev *sonm.GPUDevice
all map[uint64]*sonm.Benchmark
}, 3)

ctx, cancel := context.WithCancel(m.ctx)
defer cancel()

wg, ctx := errgroup.WithContext(ctx)
for i := 0; i < 3; i++ {
wg.Go(func() error {
for dev := range devChan {
if err := m.setBenchmark(dev.bench, dev.dev, dev.all); err != nil {
return err
}
}
return nil
})
}
if err := group.Wait(); err != nil {

for _, dev := range m.hardware.GPU {
devChan <- struct {
bench *sonm.Benchmark
dev *sonm.GPUDevice
all map[uint64]*sonm.Benchmark
}{bench: bench, dev: dev.GetDevice(), all: dev.GetBenchmarks()}
}

close(devChan)

if err := wg.Wait(); err != nil {
return err
}
default:
Expand Down