Skip to content

Document a Sonic 1 leftover in the sound driver. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Totally-Not-Filter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document a Sonic 1 leftover in the sound driver. #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions s2.sounddriver.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3016,6 +3016,8 @@ cfPanningAMSFMS:
; change the panning of a given channel.

bit 7,(ix+zTrack.VoiceControl) ; Is this a PSG track?
; The following return check is a leftover from Sonic 1, where it returns if VoiceControl is negative (i.e. 80h or higher).
; A not zero check would make this more consistent with the rest of the sound driver.
ret m ; If so, quit!
if ~~FixDriverBugs
; This check is in the wrong place.
Expand Down