libyang3: install libyang3 debs instead of libyang1#189
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sonic-buildimage no longer builds the libyang1 debs (libyang_1.0.73, libyang-cpp, python3-yang); it now builds only libyang3. - Dockerfile.common.prod: install the libyang3 runtime deb via a versionless glob (libyang3_*.deb). - copy.sh / dependencies.conf: the sonic-build artifacts API requires an exact filename (wildcards are not resolved), so these name the concrete libyang3 deb (libyang3_3.12.2-1), consistent with every other pinned dependency in these files. copy.sh also moves the libyang fetch to the bookworm path, since libyang3 is not built for buster. Part of sonic-net/sonic-buildimage#22385. Signed-off-by: Brad House <bhouse@nexthop.ai>
bhouse-nexthop
force-pushed
the
bhouse.libyang3-debs
branch
from
d55bbdc to
f6604b1
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 189 in repo sonic-net/sonic-restapi |
rookie-who
left a comment
rookie-who
left a comment
There was a problem hiding this comment.
LGTM — clean migration to libyang3. Minor note: copy.sh now points to bookworm while other debs still reference buster; assuming intentional since libyang3 is only available in bookworm.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
Retrying failed(or canceled) stages in build 1129428: ✅Stage __default: |
|
/azpw run |
|
Retrying failed(or canceled) jobs... |
|
Retrying failed(or canceled) stages in build 1129428: ✅Stage __default: |
4 participants
Why I did it
sonic-buildimageno longer builds the legacy libyang1 debs (libyang_1.0.73,libyang-cpp,python3-yang); it now builds only libyang3 (libyang3,python3-libyang). The prebuilt-deb references here would break once libyang1 is gone.Part of the libyang3 migration tracked in sonic-net/sonic-buildimage#22385.
How I did it
Dockerfile.common.prod— install the libyang3 runtime deb from/debsvia a versionless glob (libyang3_*.deb).copy.sh/dependencies.conf— thesonic-buildartifacts API requires an exact artifact filename (wildcardtarget=does not resolve), so these name the concretelibyang3_3.12.2-1deb, consistent with every other version-pinned dependency in these files.copy.shalso moves the libyang fetch to thebookwormartifact path, since libyang3 is not built forbuster.These pinned references will need a bump when libyang3's version changes — exactly as the other pinned debs in these files already do; only the Dockerfile install uses a versionless glob.
How to verify it
libyang3_3.12.2-1_amd64.debis published on currentsonic-buildimagemaster (bookworm) and downloads via the artifacts API; the Docker build installs it through the/debs/libyang3_*.debglob.Description for the changelog
libyang3: install libyang3 instead of libyang1 (Dockerfile glob + version-pinned artifact references).