Support for multipart file upload.#493
Closed
rajasimon-precisionformedicine wants to merge 7 commits intomasterfrom
Closed
Support for multipart file upload.#493rajasimon-precisionformedicine wants to merge 7 commits intomasterfrom
rajasimon-precisionformedicine wants to merge 7 commits intomasterfrom
Conversation
* Update github-runner to use Ubuntu-24.04 * Update GH runner to ubuntu-22.04 * pypy instad of pypy3 * remove pypy * Update actions versions * reformat files * reformat files * add python 3.9 to tests --------- Co-authored-by: Tatjana Damnjanović <tatjana.damnjanovic@precisionformedicine.com> Co-authored-by: Tatjana Damnjanović <tatjana@solvebio.com>
| mimetype = mime_tuple[1] if mime_tuple[1] else mime_tuple[0] | ||
| # Get file size | ||
| size = os.path.getsize(local_path) | ||
| if size == 0: |
Contributor
There was a problem hiding this comment.
Why did you remove this part? We should skip the empty files.
| pass | ||
|
|
||
| # Lookup parent object | ||
| if kwargs.get('follow_shortcuts') and obj and obj.is_file: |
Contributor
There was a problem hiding this comment.
We need this logic for the shortcuts resolution, so this shouldn't be removed
Collaborator
Author
|
This is merged as part of this PR #498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File larger than 5Gb failed because of the technical limitation but with the multi part upload feature the files are upload in chunks.