Skip to content

[EDPDEV-2598] fix branch depth for single file download #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damnjanovictanja merged 1 commit into from
May 8, 2025
Merged

[EDPDEV-2598] fix branch depth for single file download #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion solvebio/cli/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,9 +746,11 @@ def _download_recursive(

min_depth = min([x.depth for x in remote_objects])
num_at_min_depth = len([x for x in remote_objects if x.depth == min_depth])
if num_at_min_depth == 1:
if num_at_min_depth == 1 and not _is_single_file(remote_objects):
# when downloading from folder
base_folder_depth = min_depth
else:
# when downloading from vault root or singular file
base_folder_depth = min_depth - 1

downloaded_files = set()
Expand Down Expand Up @@ -932,6 +934,10 @@ def _get_relative_download_path(base_path, path_to_object, filename):
return filename


def _is_single_file(objects):
return len(objects) == 1 and objects[0].get("object_type") == "file"


def ls(args):
"""
Given a SolveBio remote path, list the files and folders
Expand Down
Loading