Chore **/CMakeLists.txt, .github/**.yml: Upgrade CMake to version>=4 #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the minimum required version to 4.0.1 in **/CMakeLists.txt - Install CMake=4.0.1 to every GA runner.
ThreeMonth03
commented
Jan 25, 2026
Collaborator
Author
ThreeMonth03
left a comment
ThreeMonth03
left a comment
There was a problem hiding this comment.
@yungyuc Please review this issue. Thanks.
Comment on lines
-40
to
+48
| sudo curl git build-essential make cmake libc6-dev gcc g++ \ | ||
| sudo curl git build-essential make libc6-dev gcc g++ \ | ||
| python3 python3-dev python3-venv | ||
|
|
||
| # The latest CMake version from apt-get is 3.28.3, so we install CMake>=4.0.1 from github marketplace. | ||
| - name: install CMake=4.0.1 | ||
| uses: lukka/get-cmake@latest | ||
| with: | ||
| cmakeVersion: 4.0.1 | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Upgrade CMake from another github actions.
| - name: setup.py install build_ext | ||
| run: | | ||
| sudo python3 setup.py install build_ext \ | ||
| sudo env "PATH=$PATH" python3 setup.py install build_ext \ |
Collaborator
Author
There was a problem hiding this comment.
When running the command with sudo, the command would use the original cmake and raise error.
In this discussion, the author suggests to pass the enviroment variables to bypass the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
According to the discussion in issue #648, we decide to upgrade the CMake to version>=4.
Solution
The latest version of cmake is
4.2.2. Due to the script in devenv, this pull request upgrade the CMake to version=4.0.1, includingCMakeLists.txtand.github/**.yml.