Refine mobile annotation toolbar interactions#3
Refine mobile annotation toolbar interactions#3solrachix wants to merge 1 commit intomobile/pdf-render-debug-and-mobile-uxfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9e2e0633d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "comment" | ||
| ); | ||
| }), | ||
| [isNative, resolvedActiveTool, layout.width, layout.height] |
There was a problem hiding this comment.
The commentTapGesture memo omits addAnnotationAt (and therefore omits state it closes over, such as current annotationColor), so the tap handler can run with stale values when those settings change while comment mode stays active. A reproducible case is changing the annotation color and then tapping to place a note: the created comment can keep the previous color until one of the listed memo deps changes. Please include the callback/state in dependencies (or memoize addAnnotationAt with the right deps) so note creation always uses current settings.
Useful? React with 👍 / 👎.
| bounces={false} | ||
| contentContainerStyle={styles.primaryToolsRow} | ||
| > | ||
| <View style={styles.primaryToolsRow}> |
There was a problem hiding this comment.
Switching the main toolbar row from a horizontal ScrollView to a plain View removes overflow handling, but the row still uses fixed-width groups/buttons (historyGroup, controlsGroup, and fixed tool widths). On narrow devices (for example ~320pt width), the center tools no longer fit and are clipped (especially with container using overflow: "hidden"), making some controls partially or fully inaccessible. Keeping horizontal scrolling or making the row fully shrinkable would prevent this regression.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing