Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
@chatgpt-codex-connector review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR focuses on the mobile reading experience and the Android PDF rendering regression introduced during the mobile shell work.
It currently includes:
Mobile UX changes
ReadingShellfor mobile with floating top controlsBug fix
Packages affected
The diff against
maincurrently touches these publishable packages:@papyrus-sdk/core@papyrus-sdk/engine-native@papyrus-sdk/types@papyrus-sdk/ui-react-native@papyrus-sdk/ui-reactOther non-package changes are in:
examples/mobileexamples/webpackage.json,pnpm-lock.yaml,eslint.config.js,vitest.config.ts,vitest.setup.ts)Release impact
Recommended packages to bump from this branch:
@papyrus-sdk/engine-native@papyrus-sdk/types@papyrus-sdk/core@papyrus-sdk/ui-react-native@papyrus-sdk/ui-reactValidation
Validated locally with:
pnpm --filter @papyrus-sdk/engine-native buildpnpm --filter @papyrus-sdk/ui-react-native buildpnpm lint:phase1cd examples/mobile && pnpm lintcd examples/mobile && pnpm exec jest --runInBand App.test.tsxcd examples/mobile && npx react-native bundle --platform android --dev true --entry-file index.js --bundle-output .bundle/index.android.bundle --assets-dest .bundle/assets --reset-cacheNotes