Skip to content

fix onBeforeResponse #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huseeiin wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

fix onBeforeResponse #2053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0265f3f
fix onBeforeResponse
huseeiin Jan 19, 2026
68b74a5
add changeset
huseeiin Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eager-wings-crash.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": minor
---

fix onBeforeResponse
2 changes: 1 addition & 1 deletion packages/start/src/middleware/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function wrapResponseMiddleware(onBeforeResponse: ResponseMiddleware): Middlewar

const fetchEvent = getFetchEvent(h3Event);
const mwResponse = await onBeforeResponse(fetchEvent, {
body: (resp as any)?.body,
body: resp,
Copy link
Contributor

@brenelz brenelz Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this change do?

Copy link
Contributor Author

@huseeiin huseeiin Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this change do?

that's how h3 v2 provides the body, different from h3 v1 which provided it through the .body property

});
if (mwResponse) return mwResponse;
};
Expand Down
Loading