fix: Enhance route matching to return isPage flag and add tests for…#1927
Merged
brenelz merged 4 commits intosolidjs:mainfrom Sep 11, 2025
Merged
fix: Enhance route matching to return isPage flag and add tests for…#1927brenelz merged 4 commits intosolidjs:mainfrom
isPage flag and add tests for…#1927brenelz merged 4 commits intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 84c950d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
More templates
commit: |
dennev
force-pushed
the
main
branch
2 times, most recently
from
03019bd to
e631165
Compare
brenelz
reviewed
Aug 19, 2025
… plain text API response and Missing page handling that has both api/file routes.
Contributor
|
@birkskyum @Brendonovich any thoughts on this? |
atilafassina
approved these changes
Sep 10, 2025
brenelz
approved these changes
Sep 10, 2025
Contributor
Author
|
@atilafassina Sure thing. I've resolved the conflicts and merged the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… plain text API response and Missing page handling that has both api/file routes.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
The
content-typeistext/htmlfor the plain-text API response.What is the new behavior?
It keeps both API/file routes in one path, and the
content-typewill betext/plainfor plain-text API responses.Other information
Adds a test for plain text API response and a test for handling missing pages with both API/file routes.